From a24dbf67ec0404657c33977a6ebacf1af3f753c9 Mon Sep 17 00:00:00 2001 From: Abhijeet Prasad Date: Wed, 12 Jul 2023 12:21:11 -0400 Subject: [PATCH] fix(node): Set propagation context even when tracingOptions are not defined --- packages/node/src/handlers.ts | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/packages/node/src/handlers.ts b/packages/node/src/handlers.ts index 6d2545c3bf9d..1d1ef3bed507 100644 --- a/packages/node/src/handlers.ts +++ b/packages/node/src/handlers.ts @@ -53,15 +53,6 @@ export function tracingHandler(): ( return next(); } - if (!hasTracingEnabled(options)) { - __DEBUG_BUILD__ && - logger.warn( - 'Sentry `tracingHandler` is being used, but tracing is disabled. Please enable tracing by setting ' + - 'either `tracesSampleRate` or `tracesSampler` in your `Sentry.init()` options.', - ); - return next(); - } - const sentryTrace = req.headers && isString(req.headers['sentry-trace']) ? req.headers['sentry-trace'] : undefined; const baggage = req.headers?.baggage; const { traceparentData, dynamicSamplingContext, propagationContext } = tracingContextFromHeaders( @@ -70,6 +61,10 @@ export function tracingHandler(): ( ); hub.getScope().setPropagationContext(propagationContext); + if (!hasTracingEnabled(options)) { + return next(); + } + const [name, source] = extractPathForTransaction(req, { path: true, method: true }); const transaction = startTransaction( {