From 651e1b0928abe761316b7abd974b029f4bcdd321 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= Date: Sat, 13 Aug 2022 06:13:17 +0200 Subject: [PATCH 1/2] fixup! Add a GitHub workflow to monitor component updates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As we've discovered with Git 2.37.1, our workflow to inform us about component updates can miss embargoed git releases, since GitHub usues the tag creation date as the publication date for their feeds. To prevent similar issues with other components in the future, let's increase the time span we look at for new feed items, as discussed in https://github.com/git-for-windows/git/pull/3948#issuecomment-1185530610 Signed-off-by: Matthias Aßhauer --- .github/workflows/monitor-components.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/monitor-components.yml b/.github/workflows/monitor-components.yml index 9c78d6d3e92445..dc98274e334c38 100644 --- a/.github/workflows/monitor-components.yml +++ b/.github/workflows/monitor-components.yml @@ -12,7 +12,7 @@ on: env: CHARACTER_LIMIT: 5000 - MAX_AGE: 48h + MAX_AGE: 7d jobs: job: From c8dc9000bf691d3b37ea5440f2109a5b5713fde2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matthias=20A=C3=9Fhauer?= Date: Sat, 13 Aug 2022 06:20:59 +0200 Subject: [PATCH 2/2] fixup! Add a GitHub workflow to monitor component updates MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `environment` keyword makes GitHub Actions believe this is a deployment environment [1], but we aren't deploying anything in this workflow. Having a "deployment" workflow on a frequent schedule causes some pull requests like [2] to become filled with thousands of "dscho deployed temporarily to monitor-components" messages. This was originally intended to allow this workflow to open issues, but we can instead just specify that the workflow should run with permissions to create issues and then use the generated access token. [1] https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment [2] https://github.com/git-for-windows/git/pull/3948 Signed-off-by: Matthias Aßhauer --- .github/workflows/monitor-components.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/monitor-components.yml b/.github/workflows/monitor-components.yml index dc98274e334c38..8623535e6361d9 100644 --- a/.github/workflows/monitor-components.yml +++ b/.github/workflows/monitor-components.yml @@ -17,7 +17,8 @@ env: jobs: job: runs-on: ubuntu-latest - environment: monitor-components + permissions: + issues: write strategy: matrix: component: @@ -79,7 +80,7 @@ jobs: feed: ${{matrix.component.feed}} prefix: "[New ${{matrix.component.label}} version]" labels: component-update - github-token: ${{ secrets.MONITOR_COMPONENTS_PAT }} + github-token: ${{ secrets.GITHUB_TOKEN }} character-limit: ${{ env.CHARACTER_LIMIT }} max-age: ${{ env.MAX_AGE }} aggregate: ${{matrix.component.aggregate}}