Java: format

Author: Stephan Brandauer

java/ql/src/Telemetry/AutomodelApplicationModeExtractCandidates.ql

@@ -75,7 +75,8 @@ where
     |
       sinkType, ", "
     )
-select endpoint.asNode(), message + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
+select endpoint.asNode(),
+  message + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
   CharacteristicsImpl::getRelatedLocationOrCandidate(endpoint, CallContext()), "CallContext", //
   package, "package", //
   type, "type", //

java/ql/src/Telemetry/AutomodelApplicationModeExtractNegativeExamples.ql

@@ -63,7 +63,8 @@ where
     characteristic2.hasImplications(positiveType, true, confidence2)
   ) and
   message = characteristic
-select endpoint.asNode(), message + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
+select endpoint.asNode(),
+  message + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
   CharacteristicsImpl::getRelatedLocationOrCandidate(endpoint, CallContext()), "CallContext", //
   package, "package", //
   type, "type", //

java/ql/src/Telemetry/AutomodelApplicationModeExtractPositiveExamples.ql

@@ -22,9 +22,10 @@ where
   not erroneousEndpoints(endpoint, _, _, _, _, false) and
   meta.hasMetadata(endpoint, package, type, subtypes, name, signature, input) and
   // Extract positive examples of sinks belonging to the existing ATM query configurations.
-  CharacteristicsImpl::isKnownSink(endpoint, sinkType)
-  and exists(CharacteristicsImpl::getRelatedLocationOrCandidate(endpoint, CallContext()))
-select endpoint.asNode(), sinkType + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
+  CharacteristicsImpl::isKnownSink(endpoint, sinkType) and
+  exists(CharacteristicsImpl::getRelatedLocationOrCandidate(endpoint, CallContext()))
+select endpoint.asNode(),
+  sinkType + "\nrelated locations: $@." + "\nmetadata: $@, $@, $@, $@, $@, $@.", //
   CharacteristicsImpl::getRelatedLocationOrCandidate(endpoint, CallContext()), "CallContext", //
   package, "package", //
   type, "type", //

java/ql/test/query-tests/Telemetry/AutomodelApplicationModeExtraction/Test.java

@@ -47,9 +47,9 @@ public static int compareFiles(File f1, File f2) {
 		);
 	}
 
-	public static void FilesWalkExample(String username, String sub) throws Exception {
+	public static void FilesWalkExample(Path p) throws Exception {
 		Files.walk(
-			Paths.get("test-dir"),
+			p, // not a candidate (modeled as a taint step)
 			FileVisitOption.FOLLOW_LINKS // the implicit varargs array is a candidate
 		);
 	}