Python points-to: Importing from 'unknown' gives 'unknown'.

markshannon · markshannon · commit a7029aba3458 · 2019-04-24T14:20:16.000+01:00
diff --git a/python/ql/src/semmle/python/pointsto/PointsTo.qll b/python/ql/src/semmle/python/pointsto/PointsTo.qll
@@ -607,6 +607,9 @@ module InterModulePointsTo {
             mod.attribute(name, value, orig) and
             origin = orig.asCfgNodeOrHere(f)
         )
+        or
+        PointsToInternal::pointsTo(f.getModule(_), context, ObjectInternal::unknown(), _) and
+        value = ObjectInternal::unknown() and origin = f
     }
 
     private predicate from_import_imports(ImportMemberNode f, PointsToContext context, ModuleObjectInternal mod, string name) {

Original file line number	Diff line number	Diff line change
`@@ -607,6 +607,9 @@ module InterModulePointsTo {`
`607`	`607`	`mod.attribute(name, value, orig) and`
`608`	`608`	`origin = orig.asCfgNodeOrHere(f)`
`609`	`609`	`)`
	`610`	`+ or`
	`611`	`+ PointsToInternal::pointsTo(f.getModule(_), context, ObjectInternal::unknown(), _) and`
	`612`	`+ value = ObjectInternal::unknown() and origin = f`
`610`	`613`	`}`
`611`	`614`
`612`	`615`	`private predicate from_import_imports(ImportMemberNode f, PointsToContext context, ModuleObjectInternal mod, string name) {`