JS: rename js/useless-defensive-code to js/unneeded-defensive-code

Author: Esben Sparre Andreasen

change-notes/1.19/analysis-javascript.md

@@ -25,7 +25,7 @@
 | Replacement of a substring with itself (`js/identity-replacement`) | correctness, security, external/cwe/cwe-116 | Highlights string replacements that replace a string with itself, which usually indicates a mistake. Results shown on LGTM by default. |
 | Stored cross-site scripting (`js/stored-xss`) | security, external/cwe/cwe-079, external/cwe/cwe-116 | Highlights uncontrolled stored values flowing into HTML content, indicating a violation of [CWE-079](https://cwe.mitre.org/data/definitions/79.html). Results shown on LGTM by default. |
 | Unclear precedence of nested operators (`js/unclear-operator-precedence`) | maintainability, correctness, external/cwe/cwe-783 | Highlights nested binary operators whose relative precedence is easy to misunderstand. Results shown on LGTM by default. |
-| Useless defensive code | correctness, external/cwe/cwe-570, external/cwe/cwe-571 | Highlights locations where defensive code serves no purpose. Results are shown on LGTM by default. |
+| Unneeded defensive code | correctness, external/cwe/cwe-570, external/cwe/cwe-571 | Highlights locations where defensive code is not needed. Results are shown on LGTM by default. |
 | User-controlled data in file | security, external/cwe/cwe-912 | Highlights locations where user-controlled data is written to a file. Results are not shown on LGTM by default. |
 
 ## Changes to existing queries

…ssions/UselessDefensiveProgramming.qhelp …sions/UnneededDefensiveProgramming.qhelpjavascript/ql/src/Expressions/UselessDefensiveProgramming.qhelp renamed to javascript/ql/src/Expressions/UnneededDefensiveProgramming.qhelp javascript/ql/src/Expressions/UselessDefensiveProgramming.qhelp renamed to javascript/ql/src/Expressions/UnneededDefensiveProgramming.qhelp

@@ -14,7 +14,7 @@
 
 			However, if the situation that some defensive code guards
 			against never can occur, then the defensive code serves no purpose and
-			it can safely be removed.
+			can safely be removed.
 
 		</p>
 
@@ -76,7 +76,7 @@
 			undefined</code> holds for both the situation where <code>v</code>
 			is<code>undefined</code> and the situation where <code>v</code>
 			is<code>null</code>, so the <code>v == null</code>
-			guard serves no purpose, and it can be removed:
+			guard serves no purpose, and can be removed:
 
 		</p>
 

…pressions/UselessDefensiveProgramming.ql …ressions/UnneededDefensiveProgramming.qljavascript/ql/src/Expressions/UselessDefensiveProgramming.ql renamed to javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql javascript/ql/src/Expressions/UselessDefensiveProgramming.ql renamed to javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql

@@ -1,10 +1,9 @@
 /**
- * @name Useless defensive code
- * @description If the situation some defensive code guards against never
- *              happens, then the defensive code is not needed.
+ * @name Unneeded defensive code
+ * @description Defensive code that guards against a situation that never happens is not needed.
  * @kind problem
  * @problem.severity recommendation
- * @id js/useless-defensive-code
+ * @id js/unneeded-defensive-code
  * @tags correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571