From ee9e083f2a3add726ec7b651b35f21d8ac637f79 Mon Sep 17 00:00:00 2001 From: Felicity Chapman Date: Fri, 15 Mar 2019 08:03:27 +0000 Subject: [PATCH 1/2] Minor text changes to analysis notes --- change-notes/1.20/analysis-java.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/change-notes/1.20/analysis-java.md b/change-notes/1.20/analysis-java.md index 05f2b10323f6..318d8b4f85d7 100644 --- a/change-notes/1.20/analysis-java.md +++ b/change-notes/1.20/analysis-java.md @@ -1,8 +1,5 @@ # Improvements to Java analysis -## General improvements - - ## New queries | **Query** | **Tags** | **Purpose** | @@ -15,7 +12,7 @@ | **Query** | **Expected impact** | **Change** | |----------------------------|------------------------|------------------------------------------------------------------| | Arbitrary file write during archive extraction ("Zip Slip") (`java/zipslip`) | Fewer false positive results | Results involving a sanitization step that converts a destination `Path` to a `File` are no longer reported. | -| Double-checked locking is not thread-safe (`java/unsafe-double-checked-locking`) | Fewer false positive results and more true positive results | Results that use safe publication through a `final` field are no longer reported. Results that initialize immutable types like `String` incorrectly are now reported. | +| Double-checked locking is not thread-safe (`java/unsafe-double-checked-locking`) | Fewer false positive and more true positive results | Results that use safe publication through a `final` field are no longer reported. Results that initialize immutable types like `String` incorrectly are now reported. | | Result of multiplication cast to wider type (`java/integer-multiplication-cast-to-long`) | Fewer results | Results involving conversions to `float` or `double` are no longer reported, as they were almost exclusively false positives. | ## Changes to QL libraries From e1a3fde52aa3eab184c2ee44f6486bb1c5a24015 Mon Sep 17 00:00:00 2001 From: Felicity Chapman Date: Mon, 18 Mar 2019 15:38:58 +0000 Subject: [PATCH 2/2] Remove 'change details' for new query --- change-notes/1.20/analysis-java.md | 1 - 1 file changed, 1 deletion(-) diff --git a/change-notes/1.20/analysis-java.md b/change-notes/1.20/analysis-java.md index 318d8b4f85d7..9ee85e762e48 100644 --- a/change-notes/1.20/analysis-java.md +++ b/change-notes/1.20/analysis-java.md @@ -12,7 +12,6 @@ | **Query** | **Expected impact** | **Change** | |----------------------------|------------------------|------------------------------------------------------------------| | Arbitrary file write during archive extraction ("Zip Slip") (`java/zipslip`) | Fewer false positive results | Results involving a sanitization step that converts a destination `Path` to a `File` are no longer reported. | -| Double-checked locking is not thread-safe (`java/unsafe-double-checked-locking`) | Fewer false positive and more true positive results | Results that use safe publication through a `final` field are no longer reported. Results that initialize immutable types like `String` incorrectly are now reported. | | Result of multiplication cast to wider type (`java/integer-multiplication-cast-to-long`) | Fewer results | Results involving conversions to `float` or `double` are no longer reported, as they were almost exclusively false positives. | ## Changes to QL libraries