QL 1.20 docs: Be more explicit about Java versions supported#1122
Merged
yh-semmle merged 2 commits intoMar 18, 2019
Conversation
yh-semmle
previously approved these changes
Mar 18, 2019
yh-semmle
left a comment
yh-semmle
left a comment
Contributor
There was a problem hiding this comment.
LGTM, modulo one inline comment.
|
|
||
| .. [1] The best results are achieved with COBOL code that stays close to the ANSI 85 standard. | ||
| .. [2] Java 11 refers to the language features used. Builds that execute on Java 6 or higher can be analyzed. | ||
| .. [2] Builds that execute on Java 6 or higher can be analyzed. The analysis understands Java 11 language features. |
Contributor
There was a problem hiding this comment.
Technically, "Java 6 or higher" should say "Java 6 to 11" (builds executing on early-access versions of Java 12 are not yet supported).
Contributor
Author
|
Thanks for the review. Topic updated accordingly. |
yh-semmle
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small text change makes the documentation more explicit about which Java versions are supported. This was triggered by a discussion on Slack.
@aschackmull or @yh-semmle - can you check this is clear and correct?