From d34eef82b3a8704dfbec9860fd94f09ad4c556af Mon Sep 17 00:00:00 2001 From: Luke Cartey Date: Wed, 3 Oct 2018 11:48:27 +0100 Subject: [PATCH] C#: Remove the 'security' tag from some queries These queries are only tenuously security queries, and marking them as security queries can cause them to have greater prominence than is merited by the results that they report. --- csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql | 1 - csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql | 1 - csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql | 1 - 3 files changed, 3 deletions(-) diff --git a/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql b/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql index 5525d3013944..5e21135d2ed9 100644 --- a/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql +++ b/csharp/ql/src/API Abuse/DisposeNotCalledOnException.ql @@ -9,7 +9,6 @@ * @id cs/dispose-not-called-on-throw * @tags efficiency * maintainability - * security * external/cwe/cwe-404 * external/cwe/cwe-459 * external/cwe/cwe-460 diff --git a/csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql b/csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql index 5c32576c8813..398418c10fdd 100644 --- a/csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql +++ b/csharp/ql/src/API Abuse/NoDisposeCallOnLocalIDisposable.ql @@ -8,7 +8,6 @@ * @id cs/local-not-disposed * @tags efficiency * maintainability - * security * external/cwe/cwe-404 * external/cwe/cwe-459 * external/cwe/cwe-460 diff --git a/csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql b/csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql index bed09a534751..8e7221afe366 100644 --- a/csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql +++ b/csharp/ql/src/Likely Bugs/PossibleLossOfPrecision.ql @@ -8,7 +8,6 @@ * @id cs/loss-of-precision * @tags reliability * correctness - * security * external/cwe/cwe-190 * external/cwe/cwe-192 * external/cwe/cwe-197