Python: named module utility#554
Merged
taus-semmle merged 2 commits intoJan 18, 2019
Merged
Conversation
taus-semmle
suggested changes
Nov 30, 2018
taus-semmle
left a comment
taus-semmle
left a comment
Contributor
There was a problem hiding this comment.
One minor doc comment, otherwise LGTM.
Does this merit a change note?
| /** Utility module for predicates relevant to the `ModuleObject` class. */ | ||
| module ModuleObject { | ||
|
|
||
| /** Gets a `ModuleObject` who's name is `name` */ |
Contributor
There was a problem hiding this comment.
Typo: whose. Maybe writing called `name` instead would be a less awkward construction. Might also want to add if it exists.
taus-semmle
approved these changes
Jan 18, 2019
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Accelerating go-extractor by using 'go list -deps' instead of just 'go list'
cklin
pushed a commit
that referenced
this pull request
May 23, 2022
Revert "Merge pull request #554 from xhd2015/accelerate_go_list"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a predicate
ModuleObject::named()so thatModuleObject::named("foo")can be used as a shorthand forany(ModuleObject m | m.getName() ="foo")I've added a few uses as examples, but haven't bothered hunting down all cases where it could be used to avoid pointless churn.