Address unsafe option review feedback

Filter unsafe-option candidates so keyword arguments are considered only when GitPython would actually transform at least one value into a command-line option. This avoids raising UnsafeOptionError for inert values such as None, False, or empty repeated-option lists.

Also replace the standalone string expression after Commit.unsafe_git_rev_options with a normal comment, matching the reviewer request and avoiding misleading class-body strings.

Validation:
- .venv/bin/python -m compileall -q git/cmd.py git/objects/commit.py test/test_git.py test/test_clone.py test/test_remote.py
- git diff --check
- Focused pytest/unittest execution could not run because the environment is missing pytest, ddt, and gitdb, and PyPI access failed while installing test-requirements.txt.

Author: codex

git/cmd.py

@@ -1034,7 +1034,10 @@ def _option_candidates(cls, args: Sequence[Any] = (), kwargs: Optional[Mapping[s
             option for option in cls._unpack_args([arg for arg in args if arg is not None]) if option.startswith("-")
         ]
         if kwargs:
-            options.extend(str(key) for key in kwargs)
+            for key, value in kwargs.items():
+                values = value if isinstance(value, (list, tuple)) else (value,)
+                if any(value is True or (value is not False and value is not None) for value in values):
+                    options.append(str(key))
         return options
 
     AutoInterrupt: TypeAlias = _AutoInterrupt

git/objects/commit.py

@@ -86,12 +86,11 @@ class Commit(base.Object, TraversableIterableObj, Diffable, Serializable):
     # INVARIANTS
     default_encoding = "UTF-8"
 
+    # Options to :manpage:`git-rev-list(1)` that can overwrite files.
     unsafe_git_rev_options = [
-        # This option can truncate or write arbitrary files before revision parsing.
         "--output",
         "-o",
     ]
-    """Options to :manpage:`git-rev-list(1)` that can overwrite files."""
 
     type: Literal["commit"] = "commit"
 

test/test_git.py

@@ -201,6 +201,19 @@ def test_check_unsafe_options_allows_attached_safe_short_option_values(self):
 
         Git.check_unsafe_options(options=["-oupstream", "-bcurrent"], unsafe_options=unsafe_options)
 
+    def test_option_candidates_ignore_untransformed_kwargs(self):
+        options = Git._option_candidates(
+            kwargs={
+                "output": None,
+                "upload_pack": False,
+                "exec": [],
+                "config": [None, False],
+                "max_count": 1,
+            }
+        )
+
+        self.assertEqual(options, ["max_count"])
+
     _shell_cases = (
         # value_in_call, value_from_class, expected_popen_arg
         (None, False, False),