fix(bigquery-jdbc): resolve ITOpenTelemetryTest pipeline and trace validation failures - #13898
Merged
Conversation
…validation failures
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the Maven test plugins to prefer the IPv4 stack by setting the java.net.preferIPv4Stack system property to true. Additionally, it updates the integration test ITOpenTelemetryTest to iterate through the fetched log entries to find one with a non-null trace ID, rather than assuming the first entry contains it. I have no feedback to provide.
keshavdandeva
marked this pull request as ready for review
July 27, 2026 15:31
logachev
approved these changes
Jul 27, 2026
logachev
enabled auto-merge (squash)
July 27, 2026 17:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/539501245
This PR addresses two separate failures affecting the
ITOpenTelemetryTestsuite, one causing flakiness/failures in local validation, and the other causing deterministic timeouts in the nightly CI pipeline.1. Fix Integration Test Trace ID Assertion (Logic Bug)
ITOpenTelemetryTestsuite fetched a list of connection logs from the GCP backend and blindly asserted the presence of a Trace ID on the very first log entry (entries.get(0)). However, the JDBC driver can emit logs outside the scope of a tracing span (e.g., during connection initialization or teardown). If one of these span-less logs happened to be the first one returned, the test falsely failed withLog entry must contain TraceId ==> expected: not <null>.verifyAndFetchLogs()to iterate through the retrieved logs and assert against the first log entry that actually contains a Trace ID.2. Fix CI Pipeline OTLP Exporter Timeout (Network Bug)
java.io.InterruptedIOException: timeout, caused by aNoRouteToHostExceptionwhen the OpenTelemetry Netty exporter attempted to route traffic to Google APIs over an IPv6 address (2607:f8b0...). Because the CI runner's environment lacks external IPv6 egress, the packets were silently blackholed, causing the network stack to hang until hitting the hardcoded 10-second OpenTelemetry timeout.<java.net.preferIPv4Stack>true</java.net.preferIPv4Stack>system property to themaven-surefire-pluginandmaven-failsafe-pluginconfigurations inpom.xml. This forces the JVM to completely bypass the broken IPv6 route and exclusively resolve/route to IPv4 addresses, which the CI runner successfully supports.Testing:
make integration-test test=ITOpenTelemetryTestlocally using SAgithub-actions@bigquery-devtools-drivers.iam.gserviceaccount.com. Confirmed all 6/6 tests compile and pass successfully.