fix: Removed dirs_exist_ok parameter as it's not backwards compatible - #1170
Merged
Conversation
ivanmkc
force-pushed
the
imkc--fix-copytree-error
branch
from
April 19, 2022 11:59
4b07d7e to
5f550f1
Compare
sasha-gitg
added
the
do not merge
Contributor
Author
|
I should add unit tests for this. |
ivanmkc
changed the title
sasha-gitg
removed
the
do not merge
product-auto-label
Bot
added
the
api: vertex-ai
sararob
added
do not merge
ivanmkc
force-pushed
the
imkc--fix-copytree-error
branch
from
May 23, 2022 22:16
74bb8b0 to
aa49312
Compare
product-auto-label
Bot
added
size: m
ivanmkc
changed the title
ivanmkc
force-pushed
the
imkc--fix-copytree-error
branch
from
May 23, 2022 22:18
aa49312 to
a3a4f04
Compare
ivanmkc
changed the title
ivanmkc
force-pushed
the
imkc--fix-copytree-error
branch
from
May 23, 2022 22:19
a3a4f04 to
dad3781
Compare
sasha-gitg
added
do not merge
ivanmkc
force-pushed
the
imkc--fix-copytree-error
branch
from
June 9, 2022 23:31
bcd7bc3 to
73b287b
Compare
rosiezou
self-requested a review
June 23, 2022 06:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed dirs_exist_ok parameter as it's not backwards compatible.
Decided to delete destination folder as it would keep the destination faithful to the source.
Fixes #1036