Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

docs: Mark database argument for get_by_id and its async counterpart as ignored#905

Merged
bw-yuhogg merged 3 commits into
googleapis:mainfrom
bw-yuhogg:document-ignored
Aug 9, 2023
Merged

docs: Mark database argument for get_by_id and its async counterpart as ignored#905
bw-yuhogg merged 3 commits into
googleapis:mainfrom
bw-yuhogg:document-ignored

Conversation

@bw-yuhogg

Copy link
Copy Markdown
Contributor

The Client class should be used to set the database instead.

@bw-yuhogg bw-yuhogg requested review from a team August 4, 2023 16:00
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 4, 2023
…as ignored

The Client class should be used to set the database instead.
@bw-yuhogg

Copy link
Copy Markdown
Contributor Author

@parthea parthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added optional suggestion to wording

Comment thread google/cloud/ndb/model.py Outdated
Comment thread google/cloud/ndb/model.py Outdated
Bob "Wombat" Hogg and others added 2 commits August 9, 2023 13:02
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@bw-yuhogg bw-yuhogg enabled auto-merge (squash) August 9, 2023 17:02
@bw-yuhogg bw-yuhogg changed the title Mark database argument for get_by_id and its async counterpart as ignored docs: Mark database argument for get_by_id and its async counterpart as ignored Aug 9, 2023
@bw-yuhogg bw-yuhogg added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2023
@bw-yuhogg bw-yuhogg merged commit b0f4310 into googleapis:main Aug 9, 2023
@bw-yuhogg bw-yuhogg deleted the document-ignored branch August 9, 2023 18:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants