fixup! Configuration.Testability++

Author: dahlbyk

LibGit2Sharp.Tests/ConfigurationFixture.cs

@@ -1,9 +1,7 @@
 using System;
-using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 using LibGit2Sharp.Tests.TestHelpers;
-using Moq;
 using Xunit;
 
 namespace LibGit2Sharp.Tests

LibGit2Sharp.Tests/MockingFixture.cs

@@ -95,10 +95,17 @@ public void CanFakeEnumerationOfConfiguration()
             Assert.Equal(2, fakeConfig.Object.Count());
         }
 
-        private IEnumerator<ConfigurationEntry<string>> FakeEntries()
+        private static IEnumerator<ConfigurationEntry<string>> FakeEntries()
         {
-            yield return new ConfigurationEntry<string>("foo", "bar", ConfigurationLevel.Local);
-            yield return new ConfigurationEntry<string>("baz", "quux", ConfigurationLevel.Global);
+            yield return FakeConfigurationEntry("foo", "bar", ConfigurationLevel.Local);
+            yield return FakeConfigurationEntry("baz", "quux", ConfigurationLevel.Global);
+        }
+
+        private static ConfigurationEntry<string> FakeConfigurationEntry(string key, string value, ConfigurationLevel level)
+        {
+            return Mock.Of<ConfigurationEntry<string>>(e => e.Key == key &&
+                                                            e.Value == value &&
+                                                            e.Level == level);
         }
     }
 }

LibGit2Sharp/Configuration.cs

@@ -266,6 +266,10 @@ private static Action<string, object, ConfigurationSafeHandle> GetUpdater<T>(Act
             { typeof(string), GetUpdater<string>(Proxy.git_config_set_string) },
         };
 
+        /// <summary>
+        /// Returns an enumerator that iterates through the configuration entries.
+        /// </summary>
+        /// <returns>An <see cref="IEnumerator{T}"/> object that can be used to iterate through the configuration entries.</returns>
         public virtual IEnumerator<ConfigurationEntry<string>> GetEnumerator()
         {
             return BuildConfigEntries().GetEnumerator();

LibGit2Sharp/ConfigurationEntry.cs

@@ -8,30 +8,36 @@ namespace LibGit2Sharp
     /// </summary>
     /// <typeparam name="T">The configuration value type</typeparam>
     [DebuggerDisplay("{DebuggerDisplay,nq}")]
-    public sealed class ConfigurationEntry<T>
+    public class ConfigurationEntry<T>
     {
         /// <summary>
         /// The fully-qualified option name.
         /// </summary>
-        public string Key { get; private set; }
+        public virtual string Key { get; private set; }
 
         /// <summary>
         /// The option value.
         /// </summary>
-        public T Value { get; private set; }
+        public virtual T Value { get; private set; }
 
         /// <summary>
         /// The origin store.
         /// </summary>
-        public ConfigurationLevel Level { get; private set; }
+        public virtual ConfigurationLevel Level { get; private set; }
+
+        /// <summary>
+        /// Needed for mocking purposes.
+        /// </summary>
+        protected ConfigurationEntry()
+        { }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ConfigurationEntry{T}"/> class with a given key and value
         /// </summary>
         /// <param name="key">The option name</param>
         /// <param name="value">The option value</param>
         /// <param name="level">The origin store</param>
-        public ConfigurationEntry(string key, T value, ConfigurationLevel level)
+        internal ConfigurationEntry(string key, T value, ConfigurationLevel level)
         {
             Key = key;
             Value = value;