NativeMethods: drop unnecessary libgit2 refcount

Remove the refcounting of libgit2 usage leftover from when
`SafeHandleBase` ensured that all handles were finished before calling
`git_libgit2_shutdown`.

libgit2 itself does this refcounting now, we no longer need to.  We only
need to call `git_libgit2_init` before the first call to libgit2 and
`git_libgit2_shutdown` at the end.

Author: ethomson

LibGit2Sharp/Core/NativeMethods.cs

@@ -14,51 +14,27 @@ internal static class NativeMethods
     {
         public const uint GIT_PATH_MAX = 4096;
         private const string libgit2 = NativeDllName.Name;
-        // This is here to keep the pointer alive
+
+        // An object tied to the lifecycle of the NativeMethods static class.
+        // This will handle initialization and shutdown of the underlying
+        // native library.
         #pragma warning disable 0414
         private static readonly LibraryLifetimeObject lifetimeObject;
-        #pragma warning restore 0414
-        private static int handlesCount;
-
-        /// <summary>
-        /// Internal hack to ensure that the call to git_threads_shutdown is called after all handle finalizers
-        /// have run to completion ensuring that no dangling git-related finalizer runs after git_threads_shutdown.
-        /// There should never be more than one instance of this object per AppDomain.
-        /// </summary>
+
         private sealed class LibraryLifetimeObject : CriticalFinalizerObject
         {
-            // Ensure mono can JIT the .cctor and adjust the PATH before trying to load the native library.
-            // See https://github.com/libgit2/libgit2sharp/pull/190
             [MethodImpl(MethodImplOptions.NoInlining)]
             public LibraryLifetimeObject()
             {
-                int res = git_libgit2_init();
-                Ensure.Int32Result(res);
-                if (res == 1)
+                // Configure the OpenSSL locking on the true initialization
+                // of the library.
+                if (git_libgit2_init() == 1)
                 {
-                    // Ignore the error that this propagates. Call it in case openssl is being used.
                     git_openssl_set_locking();
                 }
-                AddHandle();
             }
 
             ~LibraryLifetimeObject()
-            {
-                RemoveHandle();
-            }
-        }
-
-        [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)]
-        internal static void AddHandle()
-        {
-            Interlocked.Increment(ref handlesCount);
-        }
-
-        [ReliabilityContract(Consistency.WillNotCorruptState, Cer.Success)]
-        internal static void RemoveHandle()
-        {
-            int count = Interlocked.Decrement(ref handlesCount);
-            if (count == 0)
             {
                 git_libgit2_shutdown();
             }