From a3cb73b755732604798045611cf8189bb4254d2b Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Fri, 8 Oct 2021 10:37:07 -0700 Subject: [PATCH 1/3] Log tensorboard error message --- src/test/tensorBoard/tensorBoardSession.test.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/test/tensorBoard/tensorBoardSession.test.ts b/src/test/tensorBoard/tensorBoardSession.test.ts index 23c10a91aef9..ef9747314f12 100644 --- a/src/test/tensorBoard/tensorBoardSession.test.ts +++ b/src/test/tensorBoard/tensorBoardSession.test.ts @@ -113,7 +113,11 @@ suite('TensorBoard session creation', async () => { errorMessageStub.resolves(installPromptSelection); } async function createSession() { + let message = ''; errorMessageStub = sandbox.stub(applicationShell, 'showErrorMessage'); + errorMessageStub.callsFake((msg) => { + message = msg; + }); // Stub user selections sandbox.stub(applicationShell, 'showQuickPick').resolves({ label: TensorBoard.useCurrentWorkingDirectory() }); @@ -125,7 +129,7 @@ suite('TensorBoard session creation', async () => { assert.ok(session.panel?.viewColumn === ViewColumn.One, 'Panel opened in wrong group'); assert.ok(session.panel?.visible, 'Webview panel not shown on session creation golden path'); - assert.ok(errorMessageStub.notCalled, 'Error message shown on session creation golden path'); + assert.ok(errorMessageStub.notCalled, `Error message shown on session creation golden path: ${message}`); return session; } suite('Core functionality', async () => { From 583a9819775008e2d3159a75c027b2b3e5ed97b6 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Fri, 8 Oct 2021 10:59:07 -0700 Subject: [PATCH 2/3] Try installing torch tb profiler --- build/test-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/build/test-requirements.txt b/build/test-requirements.txt index 31e8b8bb1be8..03033b7d489b 100644 --- a/build/test-requirements.txt +++ b/build/test-requirements.txt @@ -18,6 +18,7 @@ isort # Integrated TensorBoard tests tensorboard ; python_version > '2.7' +torch-tb-profiler ; python_version > '2.7' # Python 2.7 support. pytest==4.6.9 ; python_version == '2.7' From adf70562a4f7888e022fdda6de539ac0eefc0ffe Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel Date: Fri, 8 Oct 2021 12:33:27 -0700 Subject: [PATCH 3/3] Revert "Log tensorboard error message" This reverts commit a3cb73b755732604798045611cf8189bb4254d2b. --- src/test/tensorBoard/tensorBoardSession.test.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/test/tensorBoard/tensorBoardSession.test.ts b/src/test/tensorBoard/tensorBoardSession.test.ts index ef9747314f12..23c10a91aef9 100644 --- a/src/test/tensorBoard/tensorBoardSession.test.ts +++ b/src/test/tensorBoard/tensorBoardSession.test.ts @@ -113,11 +113,7 @@ suite('TensorBoard session creation', async () => { errorMessageStub.resolves(installPromptSelection); } async function createSession() { - let message = ''; errorMessageStub = sandbox.stub(applicationShell, 'showErrorMessage'); - errorMessageStub.callsFake((msg) => { - message = msg; - }); // Stub user selections sandbox.stub(applicationShell, 'showQuickPick').resolves({ label: TensorBoard.useCurrentWorkingDirectory() }); @@ -129,7 +125,7 @@ suite('TensorBoard session creation', async () => { assert.ok(session.panel?.viewColumn === ViewColumn.One, 'Panel opened in wrong group'); assert.ok(session.panel?.visible, 'Webview panel not shown on session creation golden path'); - assert.ok(errorMessageStub.notCalled, `Error message shown on session creation golden path: ${message}`); + assert.ok(errorMessageStub.notCalled, 'Error message shown on session creation golden path'); return session; } suite('Core functionality', async () => {