From b1003c3c7c93be6a8899c21e5c6c95530741c845 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?D=C3=A1vid=20Kov=C3=A1=C4=8D?= Date: Wed, 25 May 2022 19:08:35 +0200 Subject: [PATCH 1/2] Log message of GraphServiceException only once gh-480 --- src/main/java/com/microsoft/graph/http/CoreHttpProvider.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/main/java/com/microsoft/graph/http/CoreHttpProvider.java b/src/main/java/com/microsoft/graph/http/CoreHttpProvider.java index 8fd8be582..b7638a084 100644 --- a/src/main/java/com/microsoft/graph/http/CoreHttpProvider.java +++ b/src/main/java/com/microsoft/graph/http/CoreHttpProvider.java @@ -28,7 +28,6 @@ import com.microsoft.graph.httpcore.middlewareoption.RedirectOptions; import com.microsoft.graph.httpcore.middlewareoption.RetryOptions; import com.microsoft.graph.logger.ILogger; -import com.microsoft.graph.logger.LoggerLevel; import com.microsoft.graph.options.HeaderOption; import com.microsoft.graph.serializer.ISerializer; @@ -489,8 +488,7 @@ private Result processResponse(final Response re } } } catch (final GraphServiceException ex) { - final boolean shouldLogVerbosely = logger.getLoggingLevel() == LoggerLevel.DEBUG; - logger.logError("Graph service exception " + ex.getMessage(shouldLogVerbosely), ex); + logger.logError("Graph service exception", ex); throw ex; } catch (final Exception ex) { final ClientException clientException = new ClientException("Error during http request", From cc485f498f0d1f0aeee0f5dc0d2879202832e0f0 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Wed, 25 May 2022 13:59:45 -0400 Subject: [PATCH 2/2] - adds changelog entry for error message fix --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4438e123e..6f91b6eec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed +- Fixed an issue where the error message would be logged twice. #514 + ## [2.0.12] - 2022-04-22 ### Added