✨ add support for custom httpx client for V1 and V2#415
Merged
Conversation
ianardee
requested changes
Jun 8, 2026
ianardee
left a comment
Contributor
There was a problem hiding this comment.
OK for a single call, but what happens when multiple calls are made?
Also:
- what happens to the client, does it close by itself, does the user need to close it?
- does threading still work now that the client is a class variable?
More explicit testing of failure points need to be added.
Collaborator
Author
Good point, I had forgotten to add the garbage collection. Also, if they aren't using a context manager they have to manage it themselves, but not much we can do.
Yes: encode/httpx#1633
Did so, tell me if you think more are warranted |
ianardee
requested changes
Jun 9, 2026
ianardee
approved these changes
Jun 9, 2026
sebastianMindee
added a commit
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes