Skip to content

Feature upload to s3 and deploy from bucket#446

Merged
DeviaVir merged 8 commits into
motdotla:masterfrom
abetomo:feature_function_update_using_s3
Jul 24, 2018
Merged

Feature upload to s3 and deploy from bucket#446
DeviaVir merged 8 commits into
motdotla:masterfrom
abetomo:feature_function_update_using_s3

Conversation

@abetomo

@abetomo abetomo commented Jul 24, 2018

Copy link
Copy Markdown
Contributor

fixes #444

DeviaVir
DeviaVir approved these changes Jul 24, 2018
View reviewed changes

@DeviaVir DeviaVir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, did you test it out already?

@abetomo

abetomo commented Jul 24, 2018

Copy link
Copy Markdown
Contributor Author

Thank you for review.
It is already tested when creating a new one.
In the case of update, it is not tested, and it checked and there was a bug and I will fix it.

@abetomo

abetomo commented Jul 24, 2018

Copy link
Copy Markdown
Contributor Author

Fixed.
In my project, there was no problem as a result of new creation and update test.

@DeviaVir DeviaVir merged commit d09e1d3 into motdotla:master Jul 24, 2018
@abetomo abetomo deleted the feature_function_update_using_s3 branch July 24, 2018 15:37
@teebu

teebu commented Jul 24, 2018

Copy link
Copy Markdown

works, how long does it take to appear on npmjs?

@abetomo abetomo mentioned this pull request Aug 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeviaVir DeviaVir DeviaVir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: upload to s3 and deploy from bucket

3 participants

@abetomo @teebu @DeviaVir