Skip to content

Fix value of StartingPosition#467

Merged
DeviaVir merged 1 commit into
motdotla:masterfrom
abetomo:supports_sqs_events
Oct 23, 2018
Merged

Fix value of StartingPosition#467
DeviaVir merged 1 commit into
motdotla:masterfrom
abetomo:supports_sqs_events

Conversation

@abetomo

@abetomo abetomo commented Oct 23, 2018

Copy link
Copy Markdown
Contributor

In the SQS event, since the value of StartingPosition is unnecessary, it returns null.

fixes #466

In the SQS event, since the value of StartingPosition is unnecessary,
it returns null.

@DeviaVir DeviaVir left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@DeviaVir DeviaVir merged commit b890e58 into motdotla:master Oct 23, 2018
@abetomo abetomo deleted the supports_sqs_events branch October 23, 2018 08:31
@sandinmyjoints

Copy link
Copy Markdown

@abetomo Can you do a new release so this fix can go out?

@abetomo

abetomo commented Nov 15, 2018

Copy link
Copy Markdown
Contributor Author

@DeviaVir Since I will create a PR, could you please release?

@abetomo abetomo mentioned this pull request Nov 15, 2018
@abetomo

abetomo commented Nov 16, 2018

Copy link
Copy Markdown
Contributor Author

@DeviaVir Thank you!

@sandinmyjoints 0.13.0 has been released!

@sandinmyjoints

sandinmyjoints commented Nov 16, 2018 via email

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQS event source fails with 'StartingPosition is not valid for SQS event sources'

3 participants