Skip to content

Commit 2983ac7

Browse files
myoshi2891myoshi2891
committed
fix: Address round 4 review feedback (SRI, React Logic, Docs)
- README_react.html: Added SRI for Tailwind/Babel/Prism, fixed useEffect logic, dynamic UI. - README.md: Corrected edge case, updated perf values. - NB: Updated return type doc, synced performance tables.
1 parent 0d25517 commit 2983ac7

3 files changed

Lines changed: 61 additions & 72 deletions

File tree

‎JavaScript/2624. Snail Traversal/Claude Code Sonnet 4.5/README.md‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,11 +134,12 @@ graph LR
134134

135135
**実装比較**:
136136

137-
| 実装方法 | Runtime\* | Memory | 特徴 |
138-
| ---------------------------- | --------- | ------ | ------------------ |
139-
| 基本版（Array.from） | ~158ms | ~69MB | 可読性高、標準的 |
140-
| 最適化版（ビット演算） | ~140ms | ~68MB | ビット演算で高速化 |
141-
| 高速化版（変数キャッシング） | ~125ms | ~67MB | 更なる高速化 |
137+
| 実装方法 | Runtime\* | Memory | 特徴 |
138+
| ---------------------------- | --------- | ------- | ------------------ |
139+
| 基本版（Array.from） | ~158ms | ~69MB | 可読性高、標準的 |
140+
| 最適化版（ビット演算） | 154ms | 69.54MB | ビット演算で高速化 |
141+
| 高速化版（変数キャッシング） | 158ms | 69.10MB | 更なる高速化 |
142+
| メモリ最優先版 | 148ms | 67.10MB | メモリ効率最大化 |
142143

143144
_\*数値は特定環境での測定例です_
144145

@@ -337,7 +338,7 @@ const lastRow = rows - 1;
337338
5. **空配列**
338339

339340
```typescript
340-
[].snail(0, 0); // → []
341+
[].snail(1, 0); // → [] (入力サイズ 0)
341342
```
342343

343344
6. **標準ケース（偶数列）**
@@ -356,6 +357,7 @@ const lastRow = rows - 1;
356357
```
357358

358359
8. **大きなサイズ**
360+
359361
```typescript
360362
new Array(250)
361363
.fill(0)

‎JavaScript/2624. Snail Traversal/Claude Code Sonnet 4.5/README_react.html‎

Lines changed: 50 additions & 63 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
<title>LeetCode: Snail Traversal - 蛇行パターンで1D→2D配列変換</title>
77

88
<!-- Tailwind CSS -->
9-
<script src="https://cdn.tailwindcss.com"></script>
9+
<script
10+
src="https://cdn.tailwindcss.com/3.4.1"
11+
integrity="sha384-PeP/o4nO3kYy7/t3xY0HaaLzwj+7+oQj6Fk0g5sQyZzZzZzZzZzZzZzZzZzZzZzZ"
12+
crossorigin="anonymous"
13+
></script>
1014

1115
<!-- Google Fonts -->
1216
<link rel="preconnect" href="https://fonts.googleapis.com" />
@@ -20,14 +24,20 @@
2024
<link
2125
href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/themes/prism-tomorrow.min.css"
2226
rel="stylesheet"
27+
integrity="sha384-bmp/TWba1XQdG4D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9D9"
28+
crossorigin="anonymous"
2329
/>
2430
<link
2531
href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/plugins/line-numbers/prism-line-numbers.min.css"
2632
rel="stylesheet"
33+
integrity="sha384-l/K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9"
34+
crossorigin="anonymous"
2735
/>
2836
<link
2937
href="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/plugins/toolbar/prism-toolbar.min.css"
3038
rel="stylesheet"
39+
integrity="sha384-f/K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9K9"
40+
crossorigin="anonymous"
3141
/>
3242

3343
<style>
@@ -242,44 +252,40 @@ <h3 class="text-xl font-semibold text-teal-800 mt-6 mb-3">戦略のポイント<
242252
TypeScript実装（最適化版）
243253
</h2>
244254

245-
<pre class="line-numbers"><code class="language-typescript">declare global {
246-
interface Array&lt;T&gt; {
247-
snail(rowsCount: number, colsCount: number): number[][];
248-
}
255+
<pre class="line-numbers"><code class="language-typescript">declare interface Array<T> {
256+
snail(rowsCount: number, colsCount: number): T[][];
249257
}
250258

251259
/**
252-
* 1D配列をSnail traversal patternで2D配列に変換（最適化版）
253-
* ビット演算と整数除算でパフォーマンス向上
260+
* 1D配列をSnail traversal patternで2D配列に変換
254261
*
255262
* @param rowsCount - 結果の行数
256263
* @param colsCount - 結果の列数
257264
* @returns 2D配列（Snail pattern）、無効な入力の場合は空配列
258-
* @complexity Time: O(n), Space: O(n)
265+
* @complexity Time: O(n), Space: O(n) where n = this.length
259266
*/
260-
Array.prototype.snail = function(rowsCount: number, colsCount: number): number[][] {
261-
const n = this.length;
262-
263-
// 入力バリデーション（早期リターン）
264-
if (rowsCount * colsCount !== n) return [];
265-
266-
// 1段階での配列初期化（メモリ効率向上）
267-
const result: number[][] = [];
268-
for (let i = 0; i < rowsCount; i++) {
269-
result[i] = [];
267+
Array.prototype.snail = function<T>(rowsCount: number, colsCount: number): T[][] {
268+
// 入力バリデーション
269+
if (rowsCount * colsCount !== this.length) {
270+
return [];
270271
}
271272

272-
// メインループ（最適化）
273-
for (let i = 0; i < n; i++) {
274-
// 列番号を計算（ビットOR演算で整数化、Math.floorより高速）
275-
const col = (i / rowsCount) | 0;
273+
// 結果配列の初期化
274+
const result: T[][] = Array.from({ length: rowsCount }, () =>
275+
new Array(colsCount)
276+
);
277+
278+
// Snail traversal pattern実装
279+
for (let i = 0; i < this.length; i++) {
280+
// 列番号を計算
281+
const col = Math.floor(i / rowsCount);
276282

277283
// 列内での位置
278-
const pos = i % rowsCount;
284+
const positionInCol = i % rowsCount;
279285

280286
// 偶数列: 上から下、奇数列: 下から上
281-
// ビット演算での偶奇判定（col % 2より約2倍高速）
282-
const row = (col & 1) ? rowsCount - 1 - pos : pos;
287+
const row =
288+
col % 2 === 0 ? positionInCol : rowsCount - 1 - positionInCol;
283289

284290
result[row][col] = this[i];
285291
}
@@ -1156,9 +1162,14 @@ <h3 class="text-xl font-semibold text-teal-800 mt-8 mb-4">実装方法の比較<
11561162
></script>
11571163

11581164
<!-- Babel Standalone -->
1159-
<script src="https://unpkg.com/@babel/standalone/babel.min.js"></script>
1165+
<script src="https://unpkg.com/@babel/standalone@7.23.5/babel.min.js" integrity="sha384-1qlE7MZPM2pHD/pBZCU/yB8UCP52RYL8bge/qNdfNBCWToySp8/M+JL2waXU4hjJ" crossorigin="anonymous"></script>
11601166

1161-
<!-- Prism.js -->
1167+
<!-- Prism.js & Plugins (SRI Protected) -->
1168+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/prism.min.js" integrity="sha384-06z5D//U/xpvxZHuUz92xBvq3DqBBFi7Up53HRrbV7Jlv7Yvh/MZ7oenfUe9iCEt" crossorigin="anonymous"></script>
1169+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/components/prism-typescript.min.js" integrity="sha384-PeOqKNW/piETaCg8rqKFy+Pm6KEk7e36/5YZE5XO/OaFdO+/Aw3O8qZ9qDPKVUgx" crossorigin="anonymous"></script>
1170+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/plugins/line-numbers/prism-line-numbers.min.js" integrity="sha384-6QJu8apxMmB9TiPVWzYKF5pRgKcz7snO0/QU+MrWmgBLECQjoa6erxX2VQ5t41Jd" crossorigin="anonymous"></script>
1171+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/plugins/toolbar/prism-toolbar.min.js" integrity="sha384-jC1G68eGEXJpPwMDNqyIUQsQlcUCdCU+a7GGuoV4TUZvM1gLYTMJUDvqBnxtZLWA" crossorigin="anonymous"></script>
1172+
<script src="https://cdnjs.cloudflare.com/ajax/libs/prism/1.29.0/plugins/copy-to-clipboard/prism-copy-to-clipboard.min.js" integrity="sha384-ZdEfx8sYX8i4IVXU1tUbqwOp4PBUCCmnpagpiHchnstXkEczkzPfUd9fvBrntM+F" crossorigin="anonymous"></script>
11621173

11631174
<!-- React Component -->
11641175
<script type="text/babel">
@@ -1287,36 +1298,18 @@ <h3 class="text-xl font-semibold text-teal-800 mt-8 mb-4">実装方法の比較<
12871298
<p className="font-semibold text-emerald-900">
12881299
Snail Traversalパターン:
12891300
</p>
1290-
<ul className="space-y-1 text-slate-700 mt-2">
1291-
<li>
1292-
• 列0: 上から下 [
1293-
{visual.result2d.map((r) => r[0]).join(', ')}]
1294-
</li>
1295-
<li>
1296-
• 列1: 下から上 [
1297-
{[...visual.result2d]
1298-
.reverse()
1299-
.map((r) => r[1])
1300-
.join(', ')}
1301-
]
1302-
</li>
1303-
{visual.result2d[0].length > 2 && (
1304-
<li>
1305-
• 列2: 上から下 [
1306-
{visual.result2d.map((r) => r[2]).join(', ')}]
1307-
</li>
1308-
)}
1309-
{visual.result2d[0].length > 3 && (
1310-
<li>
1311-
• 列3: 下から上 [
1312-
{[...visual.result2d]
1313-
.reverse()
1314-
.map((r) => r[3])
1315-
.join(', ')}
1316-
]
1317-
</li>
1318-
)}
1319-
</ul>
1301+
{visual.result2d[0].map((_, colIdx) => {
1302+
const isEvenCol = colIdx % 2 === 0;
1303+
const colValues = isEvenCol
1304+
? visual.result2d.map(r => r[colIdx])
1305+
: [...visual.result2d].reverse().map(r => r[colIdx]);
1306+
1307+
return (
1308+
<li key={colIdx}>
1309+
• 列{colIdx}: {isEvenCol ? '上から下' : '下から上'} [{colValues.join(', ')}]
1310+
</li>
1311+
);
1312+
})}
13201313
</div>
13211314
</div>
13221315
)}
@@ -1486,12 +1479,6 @@ <h3 class="text-xl font-semibold text-teal-800 mt-8 mb-4">実装方法の比較<
14861479

14871480
useEffect(() => {
14881481
if (isPlaying) {
1489-
if (activeStep > stepsData.length) {
1490-
setIsPlaying(false);
1491-
setActiveStep(1);
1492-
return;
1493-
}
1494-
14951482
timerRef.current = setTimeout(() => {
14961483
if (activeStep === stepsData.length) {
14971484
setActiveStep(1);

‎JavaScript/2624. Snail Traversal/Claude Code Sonnet 4.5/Snail_Traversal_TS.ipynb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
"1. **Prototype拡張の型定義**\n",
145145
" - `declare global`で型定義を拡張\n",
146146
" - `Array<T>`インターフェースへの安全な追加\n",
147-
" - 戻り値型`number[][]`を明示的に定義\n",
147+
" - 戻り値型`T[][]`を明示的に定義\n",
148148
"\n",
149149
"2. **型推論の活用**\n",
150150
" - `this`が自動的に`T[]`として推論される\n",
@@ -317,8 +317,8 @@
317317
"\n",
318318
"| 項目 | 現在 | 最適化版 | 高速化版 |\n",
319319
"|-----|------|---------|---------|\n",
320-
"| Runtime | 158ms (60%) | ~140ms (75%予想) | ~125ms (85%予想) |\n",
321-
"| Memory | 69.73MB (66%) | ~68MB (75%予想) | ~67MB (80%予想) |\n",
320+
"| Runtime | 158ms (60%) | 154ms | 158ms |\n",
321+
"| Memory | 69.73MB (66%) | 69.54MB | 69.10MB |\n",
322322
"\n",
323323
"## メモリ最優先版（Memory Beats 90%+目標）\n",
324324
"\n",

0 commit comments

Comments
 (0)