Skip to content

Commit 0002037

Browse files
gabylbaduh95
authored andcommitted
build: update configure.py for z/OS
Signed-off-by: Gaby Baghdadi <baghdadi@ca.ibm.com> PR-URL: #66449 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent a341ac4 commit 0002037

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

‎configure.py‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@
848848
static_optgroup.add_argument('--static-zoslib-gyp',
849849
action='store',
850850
dest='static_zoslib_gyp',
851-
help='path to zoslib.gyp file for includes and to link to static zoslib library')
851+
help='path to zoslib.gyp file for includes and to link to static zoslib libraries')
852852

853853
parser.add_argument('--tag',
854854
action='store',
@@ -1865,12 +1865,13 @@ def configure_mips(o, target_arch):
18651865
o['variables']['v8_host_byteorder'] = host_byteorder
18661866

18671867
def configure_zos(o):
1868-
o['variables']['node_static_zoslib'] = b(True)
1869-
if options.static_zoslib_gyp:
1870-
# Apply to all Node.js components for now
1871-
o['variables']['zoslib_include_dir'] = Path(options.static_zoslib_gyp).parent / 'include'
1868+
if os.environ.get('ZOSLIB_INCLUDES'):
1869+
o['variables']['zoslib_include_dir'] = os.environ.get('ZOSLIB_INCLUDES')
18721870
o['include_dirs'] += [o['variables']['zoslib_include_dir']]
18731871
else:
1872+
raise Exception('Environment variable ZOSLIB_INCLUDES=<path to zoslib/include dir> is required.')
1873+
1874+
if not options.static_zoslib_gyp:
18741875
raise Exception('--static-zoslib-gyp=<path to zoslib.gyp file> is required.')
18751876

18761877
def clang_version_ge(version_checked):
@@ -2795,8 +2796,8 @@ def icu_download(path):
27952796
icu_config['variables']['icu_asm_ext'] = 'S'
27962797
icu_config['variables']['icu_asm_opts'] = [ '-a', 'xlc' ]
27972798
elif sys.platform == 'zos':
2798-
icu_config['variables']['icu_asm_ext'] = 'S'
2799-
icu_config['variables']['icu_asm_opts'] = [ '-a', 'zos' ]
2799+
icu_config['variables']['icu_asm_ext'] = 'c'
2800+
icu_config['variables']['icu_asm_opts'] = []
28002801
else:
28012802
# assume GCC-compatible asm is OK
28022803
icu_config['variables']['icu_asm_ext'] = 'S'

0 commit comments

Comments
 (0)