lib,tools: add node-core/func-name-matching lint rule

And rename functions accordingly.

Signed-off-by: LiviaMedeiros <livia@cirno.name>
Co-authored-by: louiellan <louie.lou.llaneta@gmail.com>
PR-URL: #57901
Refs: #57899
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: 2 people

doc/api/modules.md

@@ -1132,7 +1132,7 @@ exports = { hello: false };  // Not exported, only available in the module
 When the `module.exports` property is being completely replaced by a new
 object, it is common to also reassign `exports`:
 
-<!-- eslint-disable func-name-matching -->
+<!-- eslint-disable node-core/func-name-matching -->
 
 ```js
 module.exports = exports = function Constructor() {

eslint.config.mjs

@@ -179,7 +179,6 @@ export default [
       'default-case-last': 'error',
       'dot-notation': 'error',
       'eqeqeq': ['error', 'smart'],
-      'func-name-matching': 'error',
       'func-style': ['error', 'declaration', { allowArrowFunctions: true }],
       'no-constant-condition': ['error', { checkLoops: false }],
       'no-constructor-return': 'error',
@@ -391,6 +390,7 @@ export default [
       'node-core/no-duplicate-requires': 'error',
       'node-core/prefer-proto': 'error',
       'node-core/prefer-optional-chaining': 'error',
+      'node-core/func-name-matching': ['error', { considerPropertyDescriptor: true }],
     },
   },
   // #endregion

lib/fs.js

@@ -304,7 +304,7 @@ function exists(path, callback) {
 
 ObjectDefineProperty(exists, kCustomPromisifiedSymbol, {
   __proto__: null,
-  value: function exists(path) { // eslint-disable-line func-name-matching
+  value: function exists(path) {
     return new Promise((resolve) => fs.exists(path, resolve));
   },
 });

lib/internal/bootstrap/web/exposed-window-or-worker.js

@@ -75,7 +75,7 @@ ObjectDefineProperty(globalThis, 'fetch', {
   configurable: true,
   enumerable: true,
   writable: true,
-  value: function fetch(input, init = undefined) { // eslint-disable-line func-name-matching
+  value: function fetch(input, init = undefined) {
     if (!fetchImpl) { // Implement lazy loading of undici module for fetch function
       const undiciModule = require('internal/deps/undici/undici');
       fetchImpl = undiciModule.fetch;

lib/internal/console/constructor.js

@@ -51,6 +51,7 @@ const {
 } = require('internal/validators');
 const { previewEntries } = internalBinding('util');
 const { Buffer: { isBuffer } } = require('buffer');
+const { assignFunctionName } = require('internal/util');
 const {
   inspect,
   formatWithOptions,
@@ -182,9 +183,9 @@ const consolePropAttributes = {
 // Fixup global.console instanceof global.console.Console
 ObjectDefineProperty(Console, SymbolHasInstance, {
   __proto__: null,
-  value(instance) {
+  value: assignFunctionName(SymbolHasInstance, function(instance) {
     return instance[kIsConsole];
-  },
+  }),
 });
 
 const kColorInspectOptions = { colors: true };
@@ -197,19 +198,19 @@ ObjectDefineProperties(Console.prototype, {
     __proto__: null,
     ...consolePropAttributes,
     // Eager version for the Console constructor
-    value: function(stdout, stderr) {
+    value: assignFunctionName(kBindStreamsEager, function(stdout, stderr) {
       ObjectDefineProperties(this, {
         '_stdout': { __proto__: null, ...consolePropAttributes, value: stdout },
         '_stderr': { __proto__: null, ...consolePropAttributes, value: stderr },
       });
-    },
+    }),
   },
   [kBindStreamsLazy]: {
     __proto__: null,
     ...consolePropAttributes,
     // Lazily load the stdout and stderr from an object so we don't
     // create the stdio streams when they are not even accessed
-    value: function(object) {
+    value: assignFunctionName(kBindStreamsLazy, function(object) {
       let stdout;
       let stderr;
       ObjectDefineProperties(this, {
@@ -232,12 +233,12 @@ ObjectDefineProperties(Console.prototype, {
           set(value) { stderr = value; },
         },
       });
-    },
+    }),
   },
   [kBindProperties]: {
     __proto__: null,
     ...consolePropAttributes,
-    value: function(ignoreErrors, colorMode, groupIndentation = 2) {
+    value: assignFunctionName(kBindProperties, function(ignoreErrors, colorMode, groupIndentation = 2) {
       ObjectDefineProperties(this, {
         '_stdoutErrorHandler': {
           __proto__: null,
@@ -277,12 +278,12 @@ ObjectDefineProperties(Console.prototype, {
           value: 'console',
         },
       });
-    },
+    }),
   },
   [kWriteToConsole]: {
     __proto__: null,
     ...consolePropAttributes,
-    value: function(streamSymbol, string) {
+    value: assignFunctionName(kWriteToConsole, function(streamSymbol, string) {
       const ignoreErrors = this._ignoreErrors;
       const groupIndent = this[kGroupIndentationString];
 
@@ -320,12 +321,12 @@ ObjectDefineProperties(Console.prototype, {
       } finally {
         stream.removeListener('error', noop);
       }
-    },
+    }),
   },
   [kGetInspectOptions]: {
     __proto__: null,
     ...consolePropAttributes,
-    value: function(stream) {
+    value: assignFunctionName(kGetInspectOptions, function(stream) {
       let color = this[kColorMode];
       if (color === 'auto') {
         color = lazyUtilColors().shouldColorize(stream);
@@ -341,12 +342,12 @@ ObjectDefineProperties(Console.prototype, {
       }
 
       return color ? kColorInspectOptions : kNoColorInspectOptions;
-    },
+    }),
   },
   [kFormatForStdout]: {
     __proto__: null,
     ...consolePropAttributes,
-    value: function(args) {
+    value: assignFunctionName(kFormatForStdout, function(args) {
       if (args.length === 1) {
         // Fast path: single string, don't call format.
         // Avoids ReflectApply and validation overhead.
@@ -358,12 +359,12 @@ ObjectDefineProperties(Console.prototype, {
       const opts = this[kGetInspectOptions](this._stdout);
       ArrayPrototypeUnshift(args, opts);
       return ReflectApply(formatWithOptions, null, args);
-    },
+    }),
   },
   [kFormatForStderr]: {
     __proto__: null,
     ...consolePropAttributes,
-    value: function(args) {
+    value: assignFunctionName(kFormatForStderr, function(args) {
       if (args.length === 1) {
         // Fast path: single string, don't call format.
         // Avoids ReflectApply and validation overhead.
@@ -375,7 +376,7 @@ ObjectDefineProperties(Console.prototype, {
       const opts = this[kGetInspectOptions](this._stderr);
       ArrayPrototypeUnshift(args, opts);
       return ReflectApply(formatWithOptions, null, args);
-    },
+    }),
   },
 });
 

lib/internal/modules/esm/hooks.js

@@ -742,7 +742,7 @@ function nextHookFactory(current, meta, { validateArgs, validateOutput }) {
   if (next) {
     nextNextHook = nextHookFactory(next, meta, { validateArgs, validateOutput });
   } else {
-    // eslint-disable-next-line func-name-matching
+    // eslint-disable-next-line node-core/func-name-matching
     nextNextHook = function chainAdvancedTooFar() {
       throw new ERR_INTERNAL_ASSERTION(
         `ESM custom loader '${hookName}' advanced beyond the end of the chain.`,

lib/internal/modules/esm/translators.js

@@ -121,7 +121,7 @@ function loadCJSModuleWithSpecialRequire(module, source, url, filename, isMain,
   }
   const cascadedLoader = require('internal/modules/esm/loader').getOrInitializeCascadedLoader();
   const __dirname = dirname(filename);
-  // eslint-disable-next-line func-name-matching,func-style
+  // eslint-disable-next-line node-core/func-name-matching,func-style
   const requireFn = function require(specifier) {
     let importAttributes = kEmptyObject;
     if (!StringPrototypeStartsWith(specifier, 'node:') && !BuiltinModule.normalizeRequirableId(specifier)) {

lib/internal/per_context/domexception.js

@@ -41,7 +41,7 @@ function throwInvalidThisError(Base, type) {
     },
     toString: {
       __proto__: null,
-      value() {
+      value: function toString() {
         return `${this.name} [${key}]: ${this.message}`;
       },
       enumerable: false,

lib/internal/streams/writable.js

@@ -84,6 +84,8 @@ const {
   kOnConstructed,
 } = require('internal/streams/utils');
 
+const { assignFunctionName } = require('internal/util');
+
 const { errorOrDestroy } = destroyImpl;
 
 ObjectSetPrototypeOf(Writable.prototype, Stream.prototype);
@@ -434,12 +436,12 @@ function Writable(options) {
 
 ObjectDefineProperty(Writable, SymbolHasInstance, {
   __proto__: null,
-  value: function(object) {
-    if (FunctionPrototypeSymbolHasInstance(this, object)) return true;
+  value: assignFunctionName(SymbolHasInstance, function(instance) {
+    if (FunctionPrototypeSymbolHasInstance(this, instance)) return true;
     if (this !== Writable) return false;
 
-    return object && object._writableState instanceof WritableState;
-  },
+    return instance && instance._writableState instanceof WritableState;
+  }),
 });
 
 // Otherwise people can pipe Writable streams, which is just wrong.

lib/internal/test_runner/mock/mock_timers.js

@@ -644,7 +644,7 @@ class MockTimers {
             __proto__: null,
             configurable: true,
             writable: true,
-            value: function value(delay) {
+            value: function timeout(delay) {
               validateUint32(delay, 'delay', false);
               const controller = new AbortController();
               // Don't keep an unused binding to the timer; mock tick controls it