Skip to content

Commit 3f51c49

Browse files
panvaaduh95
authored andcommitted
test: deflake http headers timeout keepalive
The second request in the headers-timeout test could finish its headers before the next periodic timeout check ran. Leave it incomplete across multiple checking intervals before sending the remaining headers. Remove both macOS keepalive flaky expectations. c3aa86d already extended the request-timeout test's margin to allow multiple checks. Refs: #42741 Signed-off-by: Filip Skokan <panva.ip@gmail.com> Assisted-by: Claude, Codex PR-URL: #66320 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent a5ee59c commit 3f51c49

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

‎test/parallel/parallel.status‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,6 @@ test-performance-function: PASS, FLAKY
3434
test-esm-loader-hooks-inspect-wait: PASS, FLAKY
3535

3636
[$system==macos]
37-
# https://github.com/nodejs/node/issues/42741
38-
test-http-server-headers-timeout-keepalive: PASS,FLAKY
39-
test-http-server-request-timeout-keepalive: PASS,FLAKY
4037
# https://github.com/nodejs/node/issues/60050
4138
test-cluster-dgram-1: SKIP
4239

‎test/parallel/test-http-server-headers-timeout-keepalive.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ server.listen(0, common.mustCall(() => {
7070
performRequestWithDelay(
7171
client,
7272
headersTimeout / 5,
73-
headersTimeout,
73+
headersTimeout * 2,
7474
true
7575
);
7676
}, defer).unref();

0 commit comments

Comments
 (0)