Skip to content

Commit 4977e51

Browse files
kyungrae2002aduh95
authored andcommitted
sqlite: use cached strings for property keys
Signed-off-by: Kyungrae Kang <kyungrae2002@gmail.com> Assisted-by: Codex PR-URL: #65902 Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 9bdab1e commit 4977e51

1 file changed

Lines changed: 6 additions & 18 deletions

File tree

‎src/node_sqlite.cc‎

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -2197,9 +2197,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
21972197
Local<Object> options = args[1].As<Object>();
21982198

21992199
Local<Value> return_arrays_v;
2200-
if (!options
2201-
->Get(env->context(),
2202-
FIXED_ONE_BYTE_STRING(env->isolate(), "returnArrays"))
2200+
if (!options->Get(env->context(), env->return_arrays_string())
22032201
.ToLocal(&return_arrays_v)) {
22042202
return;
22052203
}
@@ -2214,9 +2212,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
22142212
}
22152213

22162214
Local<Value> read_big_ints_v;
2217-
if (!options
2218-
->Get(env->context(),
2219-
FIXED_ONE_BYTE_STRING(env->isolate(), "readBigInts"))
2215+
if (!options->Get(env->context(), env->read_bigints_string())
22202216
.ToLocal(&read_big_ints_v)) {
22212217
return;
22222218
}
@@ -2231,10 +2227,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
22312227
}
22322228

22332229
Local<Value> allow_bare_named_params_v;
2234-
if (!options
2235-
->Get(env->context(),
2236-
FIXED_ONE_BYTE_STRING(env->isolate(),
2237-
"allowBareNamedParameters"))
2230+
if (!options->Get(env->context(), env->allow_bare_named_params_string())
22382231
.ToLocal(&allow_bare_named_params_v)) {
22392232
return;
22402233
}
@@ -2250,10 +2243,7 @@ void Database::Prepare(const FunctionCallbackInfo<Value>& args) {
22502243
}
22512244

22522245
Local<Value> allow_unknown_named_params_v;
2253-
if (!options
2254-
->Get(env->context(),
2255-
FIXED_ONE_BYTE_STRING(env->isolate(),
2256-
"allowUnknownNamedParameters"))
2246+
if (!options->Get(env->context(), env->allow_unknown_named_params_string())
22572247
.ToLocal(&allow_unknown_named_params_v)) {
22582248
return;
22592249
}
@@ -5364,10 +5354,8 @@ static void Initialize(Local<Object> target,
53645354
db_tmpl,
53655355
FIXED_ONE_BYTE_STRING(isolate, "isTransaction"),
53665356
Database::IsTransactionGetter);
5367-
SetSideEffectFreeGetter(isolate,
5368-
db_tmpl,
5369-
FIXED_ONE_BYTE_STRING(isolate, "limits"),
5370-
Database::LimitsGetter);
5357+
SetSideEffectFreeGetter(
5358+
isolate, db_tmpl, env->limits_string(), Database::LimitsGetter);
53715359
Local<String> sqlite_type_key = FIXED_ONE_BYTE_STRING(isolate, "sqlite-type");
53725360
Local<v8::Symbol> sqlite_type_symbol =
53735361
v8::Symbol::For(isolate, sqlite_type_key);

0 commit comments

Comments
 (0)