From 832835f38780ae8bcf03e4715216e11ad4dc3386 Mon Sep 17 00:00:00 2001 From: Tim Perry Date: Wed, 8 Jul 2026 21:27:32 +0200 Subject: [PATCH] test: fix flaky watch + cwd + argv test-runner test Signed-off-by: Tim Perry --- .../test-run-watch-cwd-isolation-none-argv.mjs | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs b/test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs index d3faf9e89ef4a7..1066f8fc5d6c0f 100644 --- a/test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs +++ b/test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs @@ -2,7 +2,7 @@ // parent process argv when spawning the watch child. import * as common from '../common/index.mjs'; import assert from 'node:assert'; -import { readFileSync, writeFileSync } from 'node:fs'; +import { writeFileSync } from 'node:fs'; import { join } from 'node:path'; import { run } from 'node:test'; import tmpdir from '../common/tmpdir.js'; @@ -11,16 +11,13 @@ import { skipIfNoWatch } from '../common/watch.js'; skipIfNoWatch(); tmpdir.refresh(); -const marker = join(tmpdir.path, 'marker'); writeFileSync(join(tmpdir.path, 'test.js'), ` const test = require('node:test'); -const { writeFileSync } = require('node:fs'); -test('test ran from cwd', () => { - writeFileSync(${JSON.stringify(marker)}, 'ran'); -}); +test('test ran from cwd', () => {}); `); +const passed = []; const controller = new AbortController(); const stream = run({ cwd: tmpdir.path, @@ -36,8 +33,9 @@ const stream = run({ }); stream.on('test:fail', common.mustNotCall()); -stream.on('test:pass', common.mustCall(1)); +stream.on('test:pass', common.mustCall((data) => passed.push(data.name), 1)); // eslint-disable-next-line no-unused-vars for await (const _ of stream); -assert.strictEqual(readFileSync(marker, 'utf8'), 'ran'); +// Validate the expected test ran by name: +assert.deepStrictEqual(passed, ['test ran from cwd']);