Skip to content

dns: name anonymous functions#9052

Closed
maasencioh wants to merge 1 commit into
nodejs:masterfrom
maasencioh:name_dns
Closed

dns: name anonymous functions#9052
maasencioh wants to merge 1 commit into
nodejs:masterfrom
maasencioh:name_dns

Conversation

@maasencioh

@maasencioh maasencioh commented Oct 12, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • commit message follows commit guidelines
Description of change

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label Oct 12, 2016
@evanlucas

evanlucas commented Oct 12, 2016

Copy link
Copy Markdown
Contributor

Thanks for the contribution @maasencioh! I went ahead and started a CI run: https://ci.nodejs.org/job/node-test-pull-request/4487/

evanlucas
evanlucas approved these changes Oct 12, 2016
View reviewed changes

@evanlucas evanlucas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maasencioh

maasencioh commented Oct 12, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @evanlucas!, freebsd it's not passing but I don't think that is related with my change

targos
targos approved these changes Oct 12, 2016
View reviewed changes

@targos targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fhinkel
fhinkel approved these changes Oct 13, 2016
View reviewed changes

@fhinkel fhinkel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Oct 14, 2016
View reviewed changes

@jasnell jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Oct 14, 2016
View reviewed changes

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca

lpinca commented Oct 16, 2016

Copy link
Copy Markdown
Member

I've triggered another CI, just in case: https://ci.nodejs.org/job/node-test-pull-request/4534/

@jasnell jasnell self-assigned this Oct 17, 2016
jasnell pushed a commit that referenced this pull request Oct 17, 2016
@maasencioh @jasnell
dns: name anonymous functions
115bb04 
Ref: #8913
PR-URL: #9052
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Oct 17, 2016

Copy link
Copy Markdown
Member

Landed in 115bb04

@jasnell jasnell closed this Oct 17, 2016
jasnell pushed a commit that referenced this pull request Oct 17, 2016
@maasencioh @jasnell
dns: name anonymous functions
260f41f 
Ref: #8913
PR-URL: #9052
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@maasencioh maasencioh deleted the name_dns branch October 17, 2016 19:33
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 9, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkel fhinkel fhinkel approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

+1 more reviewer

@evanlucas evanlucas evanlucas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jasnell jasnell

Labels

dns Issues and PRs related to the dns subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@maasencioh @evanlucas @lpinca @jasnell @fhinkel @targos @MylesBorins @nodejs-github-bot