From 817058b5cfdde81e0598e9fc505ac23f0c136b7b Mon Sep 17 00:00:00 2001 From: Conner Bachmann Date: Wed, 16 Nov 2022 13:35:10 +0100 Subject: [PATCH 1/4] docs: warning for bugs --- docs/content/1.docs/1.getting-started/5.transitions.md | 4 ++++ .../1.docs/3.api/2.components/5.nuxt-loading-indicator.md | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/docs/content/1.docs/1.getting-started/5.transitions.md b/docs/content/1.docs/1.getting-started/5.transitions.md index 5592a22c86c..57667cd0813 100644 --- a/docs/content/1.docs/1.getting-started/5.transitions.md +++ b/docs/content/1.docs/1.getting-started/5.transitions.md @@ -19,6 +19,10 @@ export default defineNuxtConfig({ }) ``` +::alert{type=warning} +If you are using `definePageMeta` to handle dynamic layouts, the page transitions on this page will not work. +:: + To start adding transition between your pages, add the following CSS to your [`app.vue`](/docs/guide/directory-structure/app): ::code-group diff --git a/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md b/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md index c95f4491186..9c2db5deb51 100644 --- a/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md +++ b/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md @@ -19,6 +19,10 @@ Add `` in your `app.vue` or layouts. :button-link[Open on StackBlitz]{href="https://stackblitz.com/github/nuxt/framework/tree/main/examples/routing/pages?terminal=dev&file=/app.vue" blank} +::alert{type=warning} +If you are using `definePageMeta` to handle dynamic layouts, the `NuxtLoadingIndicator` will not work. +:: + ## Slots You can pass custom HTML or components through the loading indicator's default slot. From 4b7de7ef14d55c6138444e4d69cbe6096de559bb Mon Sep 17 00:00:00 2001 From: Conner Bachmann Date: Fri, 18 Nov 2022 10:27:30 +0100 Subject: [PATCH 2/4] fix(docs): updated info about pages/404.vue --- docs/content/1.docs/2.guide/2.directory-structure/1.pages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md b/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md index d33cd67e326..3b40403b9fa 100644 --- a/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md +++ b/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md @@ -151,7 +151,7 @@ Navigating to `/hello/world` would render: ``` ::alert{type="info"} -Nuxt also supports a custom `pages/404.vue` file which will handle all routes that are not otherwise matched (and set a 404 error code). +The `pages/404.vue` support was removed, if you want to create such a page, you have to create a Catch-all Route and manually set the response status 404. :: ## Nested Routes From d2cc918946fe9bc32ee736df9ecfb49aec33ebec Mon Sep 17 00:00:00 2001 From: Conner Bachmann Date: Fri, 18 Nov 2022 10:39:08 +0100 Subject: [PATCH 3/4] fix(docs): removed 404.vue alert --- docs/content/1.docs/2.guide/2.directory-structure/1.pages.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md b/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md index 3b40403b9fa..ddc5dbd6ec8 100644 --- a/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md +++ b/docs/content/1.docs/2.guide/2.directory-structure/1.pages.md @@ -150,10 +150,6 @@ Navigating to `/hello/world` would render:

["hello", "world"]

``` -::alert{type="info"} -The `pages/404.vue` support was removed, if you want to create such a page, you have to create a Catch-all Route and manually set the response status 404. -:: - ## Nested Routes It is possible to display [nested routes](https://next.router.vuejs.org/guide/essentials/nested-routes.html) with ``. From d94de40c4ebdf79a631a1ff0a353c575508b11f2 Mon Sep 17 00:00:00 2001 From: Conner Bachmann Date: Fri, 18 Nov 2022 10:43:31 +0100 Subject: [PATCH 4/4] fix: removed pr artifcats --- docs/content/1.docs/1.getting-started/5.transitions.md | 4 ---- .../1.docs/3.api/2.components/5.nuxt-loading-indicator.md | 4 ---- 2 files changed, 8 deletions(-) diff --git a/docs/content/1.docs/1.getting-started/5.transitions.md b/docs/content/1.docs/1.getting-started/5.transitions.md index 57667cd0813..5592a22c86c 100644 --- a/docs/content/1.docs/1.getting-started/5.transitions.md +++ b/docs/content/1.docs/1.getting-started/5.transitions.md @@ -19,10 +19,6 @@ export default defineNuxtConfig({ }) ``` -::alert{type=warning} -If you are using `definePageMeta` to handle dynamic layouts, the page transitions on this page will not work. -:: - To start adding transition between your pages, add the following CSS to your [`app.vue`](/docs/guide/directory-structure/app): ::code-group diff --git a/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md b/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md index 9c2db5deb51..c95f4491186 100644 --- a/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md +++ b/docs/content/1.docs/3.api/2.components/5.nuxt-loading-indicator.md @@ -19,10 +19,6 @@ Add `` in your `app.vue` or layouts. :button-link[Open on StackBlitz]{href="https://stackblitz.com/github/nuxt/framework/tree/main/examples/routing/pages?terminal=dev&file=/app.vue" blank} -::alert{type=warning} -If you are using `definePageMeta` to handle dynamic layouts, the `NuxtLoadingIndicator` will not work. -:: - ## Slots You can pass custom HTML or components through the loading indicator's default slot.