diff --git a/src/main/java/loci/common/Location.java b/src/main/java/loci/common/Location.java index 78a2be0e..8d214164 100644 --- a/src/main/java/loci/common/Location.java +++ b/src/main/java/loci/common/Location.java @@ -125,11 +125,11 @@ public Location(File file) { } public Location(String parent, String child) { - this(parent == null ? child : parent + File.separator + child); + this(parent + File.separator + child); } public Location(Location parent, String child) { - this(parent == null ? (String) null : parent.getAbsolutePath(), child); + this(parent.getAbsolutePath(), child); } // -- Location API methods -- @@ -620,9 +620,7 @@ public String getParent() { /* @see java.io.File#getParentFile() */ public Location getParentFile() { - String parent = this.getParent(); - if (parent == null) return null; - return new Location(parent); + return new Location(getParent()); } /* @see java.io.File#getPath() */ diff --git a/src/test/java/loci/common/utests/LocationTest.java b/src/test/java/loci/common/utests/LocationTest.java index bc672fd5..ddd47e78 100644 --- a/src/test/java/loci/common/utests/LocationTest.java +++ b/src/test/java/loci/common/utests/LocationTest.java @@ -33,7 +33,6 @@ package loci.common.utests; import static org.testng.AssertJUnit.assertEquals; -import static org.testng.AssertJUnit.assertNull; import java.io.File; import java.io.IOException; @@ -176,14 +175,6 @@ public void testParent() { file.getParentFile().getAbsolutePath()); } } - - @Test - public void testParentNull() { - Location nullParent = new Location((String) null, "nullParentFile"); - assertNull(nullParent.getParentFile()); - nullParent = new Location((Location) null, "nullParentFile"); - assertNull(nullParent.getParentFile()); - } @Test public void testIsDirectory() {