From dbcaa8d72548dfebb60ce051331c5d90dd158d38 Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Wed, 17 Jun 2026 15:12:10 -0400 Subject: [PATCH 1/2] fix(AngleDownIcon): Replace AngleDownIcon with RhMicronsCaretDownIcon Co-authored-by: Cursor --- .../components/SearchInput/SearchInput.tsx | 3 +- .../__snapshots__/SearchInput.test.tsx.snap | 40 ++++--------------- 2 files changed, 9 insertions(+), 34 deletions(-) diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 192b2413358..17fcb6ab9c3 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -3,7 +3,6 @@ import { css } from '@patternfly/react-styles'; import { Button, ButtonVariant } from '../Button'; import { Badge } from '../Badge'; import { Icon } from '../Icon'; -import AngleDownIcon from '@patternfly/react-icons/dist/esm/icons/angle-down-icon'; import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon'; import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; @@ -340,7 +339,7 @@ const SearchInputBase: React.FunctionComponent = ({ aria-label={nextNavigationButtonAriaLabel} isDisabled={isDisabled || isNextNavigationButtonDisabled} onClick={onNextClick} - icon={} + icon={} /> )} diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index 95eb703b18e..accf4a217db 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -770,24 +770,12 @@ exports[`SearchInput search input with hint 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + @@ -966,24 +954,12 @@ exports[`SearchInput simple search input 1`] = ` fill="currentColor" height="1em" role="img" + viewBox="0 0 20 20" width="1em" > - - - - - - + From 67257ecfaf399c7a96ccbee2b9c9faa57d5404fa Mon Sep 17 00:00:00 2001 From: Rebecca Alpert Date: Mon, 29 Jun 2026 15:16:04 -0400 Subject: [PATCH 2/2] Update to filled version --- .../src/components/SearchInput/SearchInput.tsx | 6 +++--- .../__tests__/__snapshots__/SearchInput.test.tsx.snap | 10 +++++----- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/react-core/src/components/SearchInput/SearchInput.tsx b/packages/react-core/src/components/SearchInput/SearchInput.tsx index 17fcb6ab9c3..714f208d324 100644 --- a/packages/react-core/src/components/SearchInput/SearchInput.tsx +++ b/packages/react-core/src/components/SearchInput/SearchInput.tsx @@ -7,7 +7,7 @@ import AngleUpIcon from '@patternfly/react-icons/dist/esm/icons/angle-up-icon'; import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon'; import SearchIcon from '@patternfly/react-icons/dist/esm/icons/search-icon'; import RhMicronsCaretRightIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-right-icon'; -import RhMicronsCaretDownIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-icon'; +import RhMicronsCaretDownFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-caret-down-fill-icon'; import { AdvancedSearchMenu } from './AdvancedSearchMenu'; import { TextInputGroup, TextInputGroupMain, TextInputGroupUtilities } from '../TextInputGroup'; import { InputGroup, InputGroupItem } from '../InputGroup'; @@ -339,7 +339,7 @@ const SearchInputBase: React.FunctionComponent = ({ aria-label={nextNavigationButtonAriaLabel} isDisabled={isDisabled || isNextNavigationButtonDisabled} onClick={onNextClick} - icon={} + icon={} /> )} @@ -464,7 +464,7 @@ const SearchInputBase: React.FunctionComponent = ({ onClick={onToggle} isDisabled={isDisabled} aria-expanded={isSearchMenuOpen} - icon={} + icon={} /> )} diff --git a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap index accf4a217db..d97b7dd72d9 100644 --- a/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap +++ b/packages/react-core/src/components/SearchInput/__tests__/__snapshots__/SearchInput.test.tsx.snap @@ -108,7 +108,7 @@ exports[`SearchInput advanced search 1`] = ` width="1em" > @@ -263,7 +263,7 @@ exports[`SearchInput advanced search with custom attributes 1`] = ` width="1em" > @@ -608,7 +608,7 @@ exports[`SearchInput renders search input in strict mode 1`] = ` width="1em" > @@ -774,7 +774,7 @@ exports[`SearchInput search input with hint 1`] = ` width="1em" > @@ -958,7 +958,7 @@ exports[`SearchInput simple search input 1`] = ` width="1em" >