From d05fce1c987ca129b1122e1fcf7d8f8ae1313107 Mon Sep 17 00:00:00 2001 From: ndossche <7771979+ndossche@users.noreply.github.com> Date: Wed, 15 Jul 2026 22:07:54 +0200 Subject: [PATCH] Fix unchecked BN_bin2bn() call --- ext/openssl/openssl_backend_v1.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ext/openssl/openssl_backend_v1.c b/ext/openssl/openssl_backend_v1.c index 0c1ac6b955f6..bfd01b673464 100644 --- a/ext/openssl/openssl_backend_v1.c +++ b/ext/openssl/openssl_backend_v1.c @@ -589,6 +589,11 @@ zend_string *php_openssl_dh_compute_key(EVP_PKEY *pkey, char *pub_str, size_t pu } BIGNUM *pub = BN_bin2bn((unsigned char*)pub_str, (int)pub_len, NULL); + if (pub == NULL) { + php_openssl_store_errors(); + return NULL; + } + zend_string *data = zend_string_alloc(DH_size(dh), 0); int len = DH_compute_key((unsigned char*)ZSTR_VAL(data), pub, dh); BN_free(pub);