feat(desktop): drop the command palette snapshot action

The palette path captured the previous app by hiding T3 Code, which
needed a second capture target and a window hide/show dance, and it
skipped the enabled check, so a fresh install with SnapShots off could
trigger the macOS Screen Recording prompt from the palette. The
shortcut is the one way in.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Author: juliusmarminge

apps/desktop/src/ipc/DesktopIpcHandlers.ts

@@ -48,7 +48,6 @@ import {
 } from "./methods/window.ts";
 import {
   acknowledgeSnapShot,
-  captureWindow,
   checkSnapShotShortcut,
   dismissSnapShotAnimation,
   getSnapShotState,
@@ -88,7 +87,6 @@ export const installDesktopIpcHandlers = Effect.fn("desktop.ipc.installHandlers"
   yield* ipc.handle(requestSnapShotPermissions);
   yield* ipc.handle(checkSnapShotShortcut);
   yield* ipc.handle(setSnapShotShortcutSuppressed);
-  yield* ipc.handle(captureWindow);
   yield* ipc.handle(listPendingSnapShots);
   yield* ipc.handle(readSnapShot);
   yield* ipc.handle(setSnapShotAnimationDestination);

apps/desktop/src/ipc/channels.ts

@@ -35,7 +35,6 @@ export const GET_SNAP_SHOT_STATE_CHANNEL = "desktop:get-snap-shot-state";
 export const CHECK_SNAP_SHOT_SHORTCUT_CHANNEL = "desktop:check-snap-shot-shortcut";
 export const SET_SNAP_SHOT_SHORTCUT_SUPPRESSED_CHANNEL =
   "desktop:set-snap-shot-shortcut-suppressed";
-export const CAPTURE_WINDOW_CHANNEL = "desktop:capture-window";
 export const LIST_PENDING_SNAP_SHOTS_CHANNEL = "desktop:list-pending-snap-shots";
 export const READ_SNAP_SHOT_CHANNEL = "desktop:read-snap-shot";
 export const SET_SNAP_SHOT_ANIMATION_DESTINATION_CHANNEL =

apps/desktop/src/ipc/methods/snapShot.test.ts

@@ -9,7 +9,6 @@ import * as ElectronWindow from "../../electron/ElectronWindow.ts";
 import * as ElectronDialog from "../../electron/ElectronDialog.ts";
 import * as DesktopSnapShot from "../../snapShot/DesktopSnapShot.ts";
 import {
-  captureWindow,
   checkSnapShotShortcut,
   requestSnapShotPermissions,
   setupSnapShot,
@@ -214,36 +213,6 @@ describe("window capture IPC", () => {
     }).pipe(Effect.provide(layer));
   });
 
-  it.effect("uses the manual capture path for a trusted renderer", () => {
-    let globalCaptures = 0;
-    let manualCaptures = 0;
-    const layer = Layer.mergeAll(
-      Layer.succeed(
-        ElectronWindow.ElectronWindow,
-        ElectronWindow.ElectronWindow.of({
-          main: Effect.succeed(Option.some({ webContents: { id: 7 } })),
-        } as ElectronWindow.ElectronWindow["Service"]),
-      ),
-      Layer.succeed(
-        DesktopSnapShot.DesktopSnapShot,
-        DesktopSnapShot.DesktopSnapShot.of({
-          capture: Effect.sync(() => {
-            globalCaptures += 1;
-          }),
-          captureNow: Effect.sync(() => {
-            manualCaptures += 1;
-          }),
-        } as unknown as DesktopSnapShot.DesktopSnapShot["Service"]),
-      ),
-    );
-
-    return Effect.gen(function* () {
-      yield* captureWindow.handler(undefined, { sender: { id: 7 } });
-      assert.strictEqual(globalCaptures, 0);
-      assert.strictEqual(manualCaptures, 1);
-    }).pipe(Effect.provide(layer));
-  });
-
   it.effect("forwards the accessibility permission preference from a trusted renderer", () => {
     let includeAccessibility: boolean | undefined;
     const webContents = { id: 7 };
@@ -273,7 +242,9 @@ describe("window capture IPC", () => {
 
   it.effect("rejects an untrusted renderer at the IPC boundary", () =>
     Effect.gen(function* () {
-      const exit = yield* Effect.exit(captureWindow.handler(undefined, { sender: { id: 8 } }));
+      const exit = yield* Effect.exit(
+        requestSnapShotPermissions.handler(false, { sender: { id: 8 } }),
+      );
       assert(Exit.isFailure(exit));
       const failure = Cause.findErrorOption(exit.cause);
       assert(Option.isSome(failure));

apps/desktop/src/ipc/methods/snapShot.ts

@@ -161,16 +161,6 @@ export const setSnapShotShortcutSuppressed = DesktopIpc.makeIpcMethod({
   }),
 });
 
-export const captureWindow = DesktopIpc.makeIpcMethod({
-  channel: IpcChannels.CAPTURE_WINDOW_CHANNEL,
-  payload: Schema.Void,
-  result: Schema.Void,
-  handler: Effect.fn("desktop.ipc.snapShot.capture")(function* (_, event) {
-    yield* ensureTrustedSnapShotSender(event);
-    yield* (yield* DesktopSnapShot.DesktopSnapShot).captureNow;
-  }),
-});
-
 export const listPendingSnapShots = DesktopIpc.makeIpcMethod({
   channel: IpcChannels.LIST_PENDING_SNAP_SHOTS_CHANNEL,
   payload: Schema.Void,

apps/desktop/src/preload.ts

@@ -66,7 +66,6 @@ contextBridge.exposeInMainWorld("desktopBridge", {
     ipcRenderer.invoke(IpcChannels.CHECK_SNAP_SHOT_SHORTCUT_CHANNEL, shortcut),
   setSnapShotShortcutSuppressed: (suppressed) =>
     ipcRenderer.invoke(IpcChannels.SET_SNAP_SHOT_SHORTCUT_SUPPRESSED_CHANNEL, suppressed),
-  captureWindow: () => ipcRenderer.invoke(IpcChannels.CAPTURE_WINDOW_CHANNEL),
   listPendingSnapShots: () => ipcRenderer.invoke(IpcChannels.LIST_PENDING_SNAP_SHOTS_CHANNEL),
   readSnapShot: (id) => ipcRenderer.invoke(IpcChannels.READ_SNAP_SHOT_CHANNEL, id),
   setSnapShotAnimationDestination: (destination) =>

apps/web/src/components/CommandPalette.tsx

@@ -24,7 +24,6 @@ import {
   squashAtomCommandFailure,
 } from "@t3tools/client-runtime/state/runtime";
 import {
-  type DesktopSnapShotState,
   type DesktopWslState,
   type EnvironmentId,
   type EnvironmentMachineKind,
@@ -40,7 +39,6 @@ import { useLocation, useNavigate, useParams } from "@tanstack/react-router";
 import * as Option from "effect/Option";
 import {
   ArrowLeftIcon,
-  CameraIcon,
   CornerLeftUpIcon,
   FileSearchIcon,
   FolderIcon,
@@ -85,7 +83,6 @@ import { useEnvironments, usePrimaryEnvironmentId } from "../state/environments"
 import { useProjects, useThreadShells } from "../state/entities";
 import { useThreadSearch } from "../state/queries";
 import { resolveThreadActionProjectRef, startNewThreadFromContext } from "../lib/chatThreadActions";
-import { getDesktopSnapShotBridge } from "../lib/desktopSnapShot";
 import {
   appendBrowsePathSegment,
   ensureBrowseDirectoryPath,
@@ -578,8 +575,6 @@ function OpenCommandPaletteDialog(props: {
   const pathname = useLocation({ select: (location) => location.pathname });
   const { clearOpenIntent, openIntent, openOverlayMode, setOpen } = props;
   const [query, setQuery] = useState("");
-  const snapShotBridge = getDesktopSnapShotBridge();
-  const [snapShotState, setSnapShotState] = useState<DesktopSnapShotState | null>(null);
   const deferredQuery = useDeferredValue(query);
   const isActionsOnly = deferredQuery.startsWith(">");
   const [highlightedItemValue, setHighlightedItemValue] = useState<string | null>(null);
@@ -697,19 +692,6 @@ function OpenCommandPaletteDialog(props: {
     [clientSettings],
   );
 
-  useEffect(() => {
-    let active = true;
-    void snapShotBridge
-      ?.getSnapShotState()
-      .then((state) => {
-        if (active) setSnapShotState(state);
-      })
-      .catch(() => undefined);
-    return () => {
-      active = false;
-    };
-  }, [snapShotBridge]);
-
   const environmentLabelById = useMemo(
     () =>
       new Map(
@@ -1649,19 +1631,6 @@ function OpenCommandPaletteDialog(props: {
     },
   });
 
-  if (snapShotBridge && snapShotState && snapShotState.mode !== "unavailable") {
-    actionItems.push({
-      kind: "action",
-      value: "action:capture-window",
-      searchTerms: ["capture window", "screenshot", "attach", "snap"],
-      title: "Take snapshot",
-      icon: <CameraIcon className={ITEM_ICON_CLASS} />,
-      run: async () => {
-        await snapShotBridge.captureWindow().catch(() => undefined);
-      },
-    });
-  }
-
   actionItems.push({
     kind: "action",
     value: "action:add-project",

apps/web/src/components/desktop/SnapShotCoordinator.test.ts

@@ -75,7 +75,6 @@ describe("window capture failures", () => {
         getSnapShotState: vi.fn(),
         checkSnapShotShortcut: vi.fn(),
         setSnapShotShortcutSuppressed: vi.fn(),
-        captureWindow: vi.fn(),
         listPendingSnapShots: vi.fn(),
         readSnapShot: vi.fn(),
         acknowledgeSnapShot: vi.fn(),
@@ -157,7 +156,6 @@ describe("window capture delivery", () => {
         getSnapShotState: vi.fn(),
         checkSnapShotShortcut: vi.fn(),
         setSnapShotShortcutSuppressed: vi.fn(async () => undefined),
-        captureWindow: vi.fn(async () => undefined),
         listPendingSnapShots: vi.fn(async () => []),
         readSnapShot: vi.fn(async () => ({
           id: "12345678-1234-1234-1234-123456789abc",

apps/web/src/lib/desktopSnapShot.test.ts

@@ -31,7 +31,6 @@ describe("getDesktopSnapShotBridge", () => {
       getSnapShotState: vi.fn(),
       checkSnapShotShortcut: vi.fn(),
       setSnapShotShortcutSuppressed: vi.fn(),
-      captureWindow: vi.fn(),
       listPendingSnapShots: vi.fn(),
       readSnapShot: vi.fn(),
       acknowledgeSnapShot: vi.fn(),

apps/web/src/lib/desktopSnapShot.ts

@@ -18,7 +18,6 @@ type SnapShotMethods =
   | "getSnapShotState"
   | "checkSnapShotShortcut"
   | "setSnapShotShortcutSuppressed"
-  | "captureWindow"
   | "listPendingSnapShots"
   | "readSnapShot"
   | "acknowledgeSnapShot";
@@ -32,7 +31,6 @@ export function getDesktopSnapShotBridge(): DesktopSnapShotBridge | undefined {
     typeof bridge?.getSnapShotState !== "function" ||
     typeof bridge.checkSnapShotShortcut !== "function" ||
     typeof bridge.setSnapShotShortcutSuppressed !== "function" ||
-    typeof bridge.captureWindow !== "function" ||
     typeof bridge.listPendingSnapShots !== "function" ||
     typeof bridge.readSnapShot !== "function" ||
     typeof bridge.acknowledgeSnapShot !== "function"

packages/contracts/src/ipc.ts

@@ -1235,7 +1235,6 @@ export interface DesktopBridge {
     shortcut: SnapShotShortcut,
   ) => Promise<DesktopSnapShotShortcutAvailability>;
   setSnapShotShortcutSuppressed?: (suppressed: boolean) => Promise<void>;
-  captureWindow?: () => Promise<void>;
   listPendingSnapShots?: () => Promise<readonly DesktopPendingSnapShot[]>;
   readSnapShot?: (id: string) => Promise<DesktopSnapShot>;
   setSnapShotAnimationDestination?: (