From 9b62305e61602168d8d9626828d603cc5d01ad8c Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 17:55:34 +0100 Subject: [PATCH 1/7] [DOC] Prepare CRAN submission for v0.3.1 This will be a new submission. Provide more details about the environments and how we do the tests. Adjust the change information from the last submission for clarity. --- cran-comments.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 855604d..124c526 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,6 +1,6 @@ -# bpmnVisualizationR 0.3.0.9000 +# bpmnVisualizationR 0.3.1 -This is a re-submission. In this version, we have: +This is a new submission. In this version, we have: * Corrected the URLs and removed the `LazyData` field in the [DESCRIPTION](DESCRIPTION) file. * Added a new file ([WORDLIST](inst/WORDLIST)) to allow custom words with `spelling` package. @@ -11,6 +11,10 @@ This is a re-submission. In this version, we have: - R-hub ubuntu-gcc-release (r-release) - R-hub fedora-clang-devel (r-devel) +**Notes**: +- the tests presented here were run on [rhub](https://r-hub.github.io/rhub/articles/rhub.html#prepare-a-cran-submission). +- additional tests were also run on [GitHub Actions](https://github.com/process-analytics/bpmn-visualization-R/actions/workflows/R-CMD-check.yaml). + ## R CMD check results ❯ On ubuntu-gcc-release (r-release) checking CRAN incoming feasibility ... NOTE @@ -42,10 +46,12 @@ This is a re-submission. In this version, we have: ## Response to CRAN for last submission +**Note**: the previous submission was done for version 0.3.0 of bpmnVisualizationR (commit 0cb72a6) + > Possibly misspelled words in DESCRIPTION: > BPMN (3:44, 7:66) > TypeScript (7:201) > bpmn (7:182) -These words are spelled correctly. They have been added to the [WORDLIST](inst/WORDLIST) file. \ No newline at end of file +These words are spelled correctly. They have been added to the [WORDLIST](inst/WORDLIST) file. From 89f5dca60d375f2ba5ef6c1adf840375f6da06d9 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 18:37:04 +0100 Subject: [PATCH 2/7] Improve the "rhub checks" paragraph in the release document based on feedback of the v0.3.1 checks --- MAINTAINERS.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 57e5749..e35b931 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -50,7 +50,7 @@ https://builder.r-hub.io/status/bpmnVisualizationR_X.Y.Z.tar.gz-C #### Post processing In [cran-comments.md](cran-comments.md): - At the top, add this template: -```mdxjs +```markdown # bpmnVisualizationR .9000 This is a . In this version, we have: @@ -73,10 +73,10 @@ This is a . In this version, we have: ```R cran_prep$cran_summary() ``` -- Remove all `Version contains large components (X.Y.Z.9000)"` +- Remove all `Version contains large components (X.Y.Z.9000)"` and update the counter of detected `NOTE` in the summary of all environments - If this is a `re-submission`, copy and paste the result for the last CRAN submission, and answer to false NOTES. Otherwise, remove the part: -```mdxjs +```markdown ## Response to CRAN for last submission > From b8ef16de3539cf067fef31519acf415897aa21e4 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 18:45:01 +0100 Subject: [PATCH 3/7] cran-comments.md: add rhub results --- cran-comments.md | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 124c526..46cd875 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -16,7 +16,8 @@ This is a new submission. In this version, we have: - additional tests were also run on [GitHub Actions](https://github.com/process-analytics/bpmn-visualization-R/actions/workflows/R-CMD-check.yaml). ## R CMD check results -❯ On ubuntu-gcc-release (r-release) + +❯ On windows-x86_64-devel (r-devel), ubuntu-gcc-release (r-release) checking CRAN incoming feasibility ... NOTE Maintainer: ‘Celine Souchet ’ @@ -27,8 +28,10 @@ This is a new submission. In this version, we have: BPMN (3:44, 7:66) TypeScript (7:201) +0 errors ✔ | 0 warnings ✔ | 3 notes ✖ + ❯ On fedora-clang-devel (r-devel) - checking CRAN incoming feasibility ... [5s/16s] NOTE + checking CRAN incoming feasibility ... [6s/25s] NOTE Maintainer: ‘Celine Souchet ’ New submission @@ -38,10 +41,6 @@ This is a new submission. In this version, we have: TypeScript (7:201) bpmn (7:182) -❯ On fedora-clang-devel (r-devel) - checking HTML version of manual ... NOTE - Skipping checking HTML validation: no command 'tidy' found - 0 errors ✔ | 0 warnings ✔ | 3 notes ✖ ## Response to CRAN for last submission From 0cea4fad432e2d4913449c6ee164af206c2a8a53 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 18:49:07 +0100 Subject: [PATCH 4/7] Add more info about the rhub environments --- cran-comments.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 46cd875..8edc414 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -7,9 +7,9 @@ This is a new submission. In this version, we have: ## Test environments -- R-hub windows-x86_64-devel (r-devel) -- R-hub ubuntu-gcc-release (r-release) -- R-hub fedora-clang-devel (r-devel) +- R-hub windows-x86_64-devel (r-devel). Platform: Windows Server 2022, R-devel, 64 bit +- R-hub ubuntu-gcc-release (r-release). Platform: Ubuntu Linux 20.04.1 LTS, R-release, GCC +- R-hub fedora-clang-devel (r-devel). Platform: Fedora Linux, R-devel, clang, gfortran **Notes**: - the tests presented here were run on [rhub](https://r-hub.github.io/rhub/articles/rhub.html#prepare-a-cran-submission). From b80b6e752c62b6c6251b40e7f932a258dbbfac90 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 18:54:08 +0100 Subject: [PATCH 5/7] release process: the "test environments" must provide more details --- MAINTAINERS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index e35b931..a3c6060 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -73,6 +73,8 @@ This is a . In this version, we have: ```R cran_prep$cran_summary() ``` +- In the "Test environments" paragraph, also provides the details of the environment as mentioned in the build status email. +For instance, add "Platform: Windows Server 2022, R-devel, 64 bit". - Remove all `Version contains large components (X.Y.Z.9000)"` and update the counter of detected `NOTE` in the summary of all environments - If this is a `re-submission`, copy and paste the result for the last CRAN submission, and answer to false NOTES. Otherwise, remove the part: From 0355e900c09dc527009e9b6d7a849344f1258f9f Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Mon, 30 Jan 2023 19:00:35 +0100 Subject: [PATCH 6/7] release process: improve local rhub token configuration --- MAINTAINERS.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index a3c6060..6239fac 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -27,7 +27,11 @@ install.packages("rhub") library(rhub) ``` -For the email address of the maintainer (described in [DESCRIPTION](DESCRIPTION)), `rhub` will prompt you to generate a token (on the first check), or you can [reuse one](https://r-hub.github.io/rhub/reference/validate_email.html). +Locally, configure the email address of the maintainer (described in [DESCRIPTION](DESCRIPTION)) + - retrieve the token you previously received by email + - call the [validate_email.html](https://r-hub.github.io/rhub/reference/validate_email.html) by passing the maintainer email and the token + +If you don't have any token, `rhub` will prompt you to generate a token (on the first check). #### Check Follow this procedure: https://r-hub.github.io/rhub/articles/rhub.html#prepare-a-cran-submission. From 5a63bd554a7d4ffc9890b779abeaf9d3d0c4ebdd Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Tue, 31 Jan 2023 09:08:37 +0100 Subject: [PATCH 7/7] improve wording MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Souchet Céline <4921914+csouchet@users.noreply.github.com> --- MAINTAINERS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 6239fac..128ac58 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -27,7 +27,7 @@ install.packages("rhub") library(rhub) ``` -Locally, configure the email address of the maintainer (described in [DESCRIPTION](DESCRIPTION)) +Locally, configure the email address of the maintainer (described in [DESCRIPTION](DESCRIPTION)): - retrieve the token you previously received by email - call the [validate_email.html](https://r-hub.github.io/rhub/reference/validate_email.html) by passing the maintainer email and the token