From 2dcc12e53946cabee0c9a6421ae77d7401742919 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 10:38:00 +0100 Subject: [PATCH 01/16] Add workflows for accessibility from SnowCamp --- .github/workflows/axe-core.yml | 50 +++++++++++++++++++++++++++++ .github/workflows/lighthouse.yml | 54 ++++++++++++++++++++++++++++++++ .github/workflows/pa11y.yml | 44 ++++++++++++++++++++++++++ 3 files changed, 148 insertions(+) create mode 100644 .github/workflows/axe-core.yml create mode 100644 .github/workflows/lighthouse.yml create mode 100644 .github/workflows/pa11y.yml diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml new file mode 100644 index 000000000..3b7bf3e4e --- /dev/null +++ b/.github/workflows/axe-core.yml @@ -0,0 +1,50 @@ +name: ♿️ A11Y CI with Axe Core +on: + pull_request: + paths: + - '**/.github/workflows/axe-core.yml' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + +jobs: + Axe-CLI: + runs-on: ubuntu-latest + needs: site_preview + steps: + - name: Checkout + uses: actions/checkout@v3 + - name: Use Chrome Driver + uses: nanasess/setup-chromedriver@v1 + with: + chromedriver-version: '108.0.5359.71' + - name: Install Axe CLI + run: npm install -g @axe-core/cli + + - name: Run Axe CLI + id: axe + uses: mathiasvr/command-output@v1 + with: + run: axe $WEBSITE_TO_AUDIT --chromedriver-path="/usr/local/bin/chromedriver" --exit --tags wcag2aaa + + - name: Comment pull request + if: always() + uses: marocchino/sticky-pull-request-comment@v2 + with: + GITHUB_TOKEN: ${{ secrets.GHTOKEN }} + header: axe-core-comment + recreate: true + message: | + ## ♿️ Axe report + Audited website : ${{ env.WEBSITE_TO_AUDIT }} + ``` + ${{ steps.axe.outputs.stdout }} + ${{ steps.axe.outputs.stderr }} + ``` + *This report has been generated using [@axe-core/cli](https://github.com/dequelabs/axe-core-npm/blob/develop/packages/cli).* \ No newline at end of file diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml new file mode 100644 index 000000000..931c78c40 --- /dev/null +++ b/.github/workflows/lighthouse.yml @@ -0,0 +1,54 @@ +name: ♿️ A11Y CI with Lighthouse +on: + pull_request: + paths: + - '**/.github/workflows/lighthouse.yml' + - '**/.github/workflows/lighthouse-comment.js' + - '**/.github/workflows/lighthouse-budget.json' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + +jobs: + Lighthouse-CLI: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + # Using the Lighthouse GitHub Action + # @see https://github.com/marketplace/actions/lighthouse-ci-action + - name: Run Lighthouse GitHub Action + uses: treosh/lighthouse-ci-action@v9 + id: lighthouse_audit + with: + urls: $WEBSITE_TO_AUDIT + budgetPath: .github/workflows/lighthouse-budget.json # test performance budgets + uploadArtifacts: true # save results as an action artifacts + temporaryPublicStorage: true # upload lighthouse report to the temporary storage + - name: Format lighthouse score + if: always() + id: format_lighthouse_score + uses: actions/github-script@v5 + with: + script: | + const lighthouseCommentMaker = require('./.github/workflows/lighthouse-comment.js'); + const lighthouseOutputs = { + manifest: ${{ steps.lighthouse_audit.outputs.manifest }}, + links: ${{ steps.lighthouse_audit.outputs.links }} + }; + const comment = lighthouseCommentMaker({ lighthouseOutputs }); + core.setOutput("comment", comment); + - name: Add Lighthouse stats as comment + if: always() + uses: marocchino/sticky-pull-request-comment@v2 + with: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + header: lighthouse-comment + recreate: true + message: ${{ steps.format_lighthouse_score.outputs.comment }} \ No newline at end of file diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml new file mode 100644 index 000000000..008267601 --- /dev/null +++ b/.github/workflows/pa11y.yml @@ -0,0 +1,44 @@ +name: ♿️ A11Y CI with Pa11y +on: + pull_request: + paths: + - '**/.github/workflows/pa11y.yml' + - '**/.pa11yci' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + +jobs: + Pa11y-CLI: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + - name: Install Pa11y CI + run: npm install -g pa11y-ci + - name: Run Pa11y CLI + id: pa11y + uses: mathiasvr/command-output@v1 + with: + run: pa11y-ci $WEBSITE_TO_AUDIT -c ./.pa11yci + - name: Comment pull request + uses: marocchino/sticky-pull-request-comment@v2 + if: always() + with: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + header: pa11y-comment + recreate: true + message: | + ## ♿️ Pa11y report + Audited website : ${{ env.WEBSITE_TO_AUDIT }} + ``` + ${{ steps.pa11y.outputs.stdout }} + ${{ steps.pa11y.outputs.stderr }} + ``` + *This report has been generated using [pa11y-ci](https://github.com/pa11y/pa11y-ci).* \ No newline at end of file From 7ab4a5d02409eae1b2f77c2d41b5a470f84f5830 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 10:54:19 +0100 Subject: [PATCH 02/16] Add a11ywatch workflow --- .github/workflows/a11ywatch.yml | 34 +++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/workflows/a11ywatch.yml diff --git a/.github/workflows/a11ywatch.yml b/.github/workflows/a11ywatch.yml new file mode 100644 index 000000000..f5c808cf3 --- /dev/null +++ b/.github/workflows/a11ywatch.yml @@ -0,0 +1,34 @@ +name: ♿️ A11Y CI with a11ywatch +on: + pull_request: + paths: + - '**/.github/workflows/axe-core.yml' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + + +jobs: + Lighthouse-CLI: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + # Using the Web Accessibility Evaluation GitHub Action + # @see https://github.com/marketplace/actions/web-accessibility-evaluation + - uses: a11ywatch/github-action@v1.13.0 + with: + WEBSITE_URL: $WEBSITE_TO_AUDIT + SUBDOMAINS: true + TLD: false + SITEMAP: true + FAIL_ERRORS_COUNT: 2 + LIST: true + FIX: false + UPGRADE: false \ No newline at end of file From 21d957f3b0d26352138b6d9d84d12200a3afd7dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 10:57:04 +0100 Subject: [PATCH 03/16] Add a11ytester-action workflow --- .github/workflows/a11ytester-action.yml | 28 +++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 .github/workflows/a11ytester-action.yml diff --git a/.github/workflows/a11ytester-action.yml b/.github/workflows/a11ytester-action.yml new file mode 100644 index 000000000..cccc74c4c --- /dev/null +++ b/.github/workflows/a11ytester-action.yml @@ -0,0 +1,28 @@ +name: ♿️ A11Y CI with a11ytester-action +on: + pull_request: + paths: + - '**/.github/workflows/axe-core.yml' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + + +jobs: + Lighthouse-CLI: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + # Using the a11ytester-action GitHub Action + # @see https://github.com/marketplace/actions/a11ytester-action + - name: a11ytester + uses: mikaelvesavuori/a11ytester-action@v1.0.0 + with: + urls: `[$WEBSITE_TO_AUDIT]` \ No newline at end of file From 4f54f834f577d45754b16b7625d3cb63e60bafb4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 11:05:28 +0100 Subject: [PATCH 04/16] Test to fix env --- .github/workflows/a11ytester-action.yml | 3 +-- .github/workflows/a11ywatch.yml | 3 +-- .github/workflows/axe-core.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- .github/workflows/pa11y.yml | 2 +- 5 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/a11ytester-action.yml b/.github/workflows/a11ytester-action.yml index cccc74c4c..68fe21f71 100644 --- a/.github/workflows/a11ytester-action.yml +++ b/.github/workflows/a11ytester-action.yml @@ -11,8 +11,7 @@ on: - '.nvmrc' env: - WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` - + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: Lighthouse-CLI: diff --git a/.github/workflows/a11ywatch.yml b/.github/workflows/a11ywatch.yml index f5c808cf3..3ff3c0bdb 100644 --- a/.github/workflows/a11ywatch.yml +++ b/.github/workflows/a11ywatch.yml @@ -11,8 +11,7 @@ on: - '.nvmrc' env: - WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` - + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: Lighthouse-CLI: diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml index 3b7bf3e4e..673923ee0 100644 --- a/.github/workflows/axe-core.yml +++ b/.github/workflows/axe-core.yml @@ -11,7 +11,7 @@ on: - '.nvmrc' env: - WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: Axe-CLI: diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 931c78c40..ebf520031 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -13,7 +13,7 @@ on: - '.nvmrc' env: - WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: Lighthouse-CLI: diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml index 008267601..66c7dd435 100644 --- a/.github/workflows/pa11y.yml +++ b/.github/workflows/pa11y.yml @@ -12,7 +12,7 @@ on: - '.nvmrc' env: - WEBSITE_TO_AUDIT: `https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/` + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: Pa11y-CLI: From 4e619f7258dea2717af3cd6fbef3f646cf5f0ff0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 11:06:55 +0100 Subject: [PATCH 05/16] Try to fix a11ytester-action workflow --- .github/workflows/a11ytester-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/a11ytester-action.yml b/.github/workflows/a11ytester-action.yml index 68fe21f71..1f82aa31e 100644 --- a/.github/workflows/a11ytester-action.yml +++ b/.github/workflows/a11ytester-action.yml @@ -24,4 +24,4 @@ jobs: - name: a11ytester uses: mikaelvesavuori/a11ytester-action@v1.0.0 with: - urls: `[$WEBSITE_TO_AUDIT]` \ No newline at end of file + urls: '[$WEBSITE_TO_AUDIT]' \ No newline at end of file From 3d0fb3927fcc6f07e77bcf58c08530bcee95facb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 11:08:18 +0100 Subject: [PATCH 06/16] TMP --- .github/workflows/generate-site-preview.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/generate-site-preview.yml b/.github/workflows/generate-site-preview.yml index 4a5b9819d..6df481639 100644 --- a/.github/workflows/generate-site-preview.yml +++ b/.github/workflows/generate-site-preview.yml @@ -7,7 +7,7 @@ on: branches: - main paths: - - '.github/workflows/generate-site-preview.yml' + - '.github/workflows/*' - 'src/**/*' - 'static/**/*' - 'package.json' From deefc3f28df676c223726f0de8789867a333680b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 11:55:00 +0100 Subject: [PATCH 07/16] Remove needs --- .github/workflows/axe-core.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml index 673923ee0..dcdba1104 100644 --- a/.github/workflows/axe-core.yml +++ b/.github/workflows/axe-core.yml @@ -16,7 +16,6 @@ env: jobs: Axe-CLI: runs-on: ubuntu-latest - needs: site_preview steps: - name: Checkout uses: actions/checkout@v3 From a623c85ca23c5aecc52cdaff390bc26db85e42ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 13:53:26 +0100 Subject: [PATCH 08/16] Add .pa11yci file --- .pa11yci | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .pa11yci diff --git a/.pa11yci b/.pa11yci new file mode 100644 index 000000000..f50f5a688 --- /dev/null +++ b/.pa11yci @@ -0,0 +1,9 @@ +{ + "defaults": { + "timeout": 10000, + "standard": "WCAG2AAA", + "chromeLaunchConfig": { + "args": ["--no-sandbox"] + } + } + } \ No newline at end of file From 0943d134bd50beb096acb1bfff7fbab1857cf2f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 13:55:37 +0100 Subject: [PATCH 09/16] Add files for lighthouse --- .github/workflows/lighthouse-budget.json | 31 ++++++++++++ .github/workflows/lighthouse-comment.js | 62 ++++++++++++++++++++++++ 2 files changed, 93 insertions(+) create mode 100644 .github/workflows/lighthouse-budget.json create mode 100644 .github/workflows/lighthouse-comment.js diff --git a/.github/workflows/lighthouse-budget.json b/.github/workflows/lighthouse-budget.json new file mode 100644 index 000000000..aec004f3c --- /dev/null +++ b/.github/workflows/lighthouse-budget.json @@ -0,0 +1,31 @@ +[ + { + "path": "/*", + "timings": [ + { + "metric": "interactive", + "budget": 3000 + }, + { + "metric": "first-meaningful-paint", + "budget": 2000 + } + ], + "resourceSizes": [ + { + "resourceType": "script", + "budget": 125 + }, + { + "resourceType": "total", + "budget": 300 + } + ], + "resourceCounts": [ + { + "resourceType": "third-party", + "budget": 10 + } + ] + } +] \ No newline at end of file diff --git a/.github/workflows/lighthouse-comment.js b/.github/workflows/lighthouse-comment.js new file mode 100644 index 000000000..02e8ccab8 --- /dev/null +++ b/.github/workflows/lighthouse-comment.js @@ -0,0 +1,62 @@ +// @ts-check + +/** + * @typedef {Object} Summary + * @prop {number} performance + * @prop {number} accessibility + * @prop {number} best-practices + * @prop {number} seo + * @prop {number} pwa + */ + +/** + * @typedef {Object} Manifest + * @prop {string} url + * @prop {boolean} isRepresentativeRun + * @prop {string} htmlPath + * @prop {string} jsonPath + * @prop {Summary} summary + */ + +/** + * @typedef {Object} LighthouseOutputs + * @prop {Record} links + * @prop {Manifest[]} manifest + */ + +const formatScore = (/** @type { number } */ score) => Math.round(score * 100); +const emojiScore = (/** @type { number } */ score) => + score >= 0.9 ? '🟢' : score >= 0.5 ? '🟠' : '🔴'; + +const scoreRow = ( + /** @type { string } */ label, + /** @type { number } */ score +) => `| ${emojiScore(score)} ${label} | ${formatScore(score)} |`; + +/** + * @param {LighthouseOutputs} lighthouseOutputs + */ +function makeComment(lighthouseOutputs) { + const { summary } = lighthouseOutputs.manifest[0]; + const [[testedUrl, reportUrl]] = Object.entries(lighthouseOutputs.links); + + const comment = `## ⚡️🏠 Lighthouse report + Audited website : [${testedUrl}](${testedUrl}) + Complete report is [here](${reportUrl}). Here's the summary: + + | Category | Score | + | -------- | ----- | + ${scoreRow('Performance', summary.performance)} + ${scoreRow('Accessibility', summary.accessibility)} + ${scoreRow('Best practices', summary['best-practices'])} + ${scoreRow('SEO', summary.seo)} + ${scoreRow('PWA', summary.pwa)} + *This report has been generated using [lighthouse](https://github.com/GoogleChrome/lighthouse).* + `; + + return comment; +} + +module.exports = ({ lighthouseOutputs }) => { + return makeComment(lighthouseOutputs); +}; \ No newline at end of file From a675a9efd345db9c86ea6bb859e4cd544cfbcb97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 14:00:21 +0100 Subject: [PATCH 10/16] Fix token --- .github/workflows/axe-core.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml index dcdba1104..e56cde42a 100644 --- a/.github/workflows/axe-core.yml +++ b/.github/workflows/axe-core.yml @@ -36,7 +36,7 @@ jobs: if: always() uses: marocchino/sticky-pull-request-comment@v2 with: - GITHUB_TOKEN: ${{ secrets.GHTOKEN }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} header: axe-core-comment recreate: true message: | From ad6f677f8469b1e157562b9cdd99443dfd2fdfcc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 14:14:57 +0100 Subject: [PATCH 11/16] Update tokens --- .github/workflows/a11ywatch.yml | 3 ++- .github/workflows/axe-core.yml | 2 +- .github/workflows/lighthouse.yml | 2 +- .github/workflows/pa11y.yml | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/a11ywatch.yml b/.github/workflows/a11ywatch.yml index 3ff3c0bdb..21da9a2c7 100644 --- a/.github/workflows/a11ywatch.yml +++ b/.github/workflows/a11ywatch.yml @@ -30,4 +30,5 @@ jobs: FAIL_ERRORS_COUNT: 2 LIST: true FIX: false - UPGRADE: false \ No newline at end of file + UPGRADE: false + TOKEN: ${{ secrets.GH_RELEASE_TOKEN }} \ No newline at end of file diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml index e56cde42a..a63fb1313 100644 --- a/.github/workflows/axe-core.yml +++ b/.github/workflows/axe-core.yml @@ -36,7 +36,7 @@ jobs: if: always() uses: marocchino/sticky-pull-request-comment@v2 with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GH_RELEASE_TOKEN }} header: axe-core-comment recreate: true message: | diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index ebf520031..11db0bbe1 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -48,7 +48,7 @@ jobs: if: always() uses: marocchino/sticky-pull-request-comment@v2 with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GH_RELEASE_TOKEN }} header: lighthouse-comment recreate: true message: ${{ steps.format_lighthouse_score.outputs.comment }} \ No newline at end of file diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml index 66c7dd435..1918efb80 100644 --- a/.github/workflows/pa11y.yml +++ b/.github/workflows/pa11y.yml @@ -31,7 +31,7 @@ jobs: uses: marocchino/sticky-pull-request-comment@v2 if: always() with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ secrets.GH_RELEASE_TOKEN }} header: pa11y-comment recreate: true message: | From c4e0c98abe19c969b17c05105531dc985ba9c44b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 16:09:40 +0100 Subject: [PATCH 12/16] Update workflows --- .github/workflows/a11ytester-action.yml | 4 ++-- .github/workflows/a11ywatch.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/a11ytester-action.yml b/.github/workflows/a11ytester-action.yml index 1f82aa31e..d0b586b4e 100644 --- a/.github/workflows/a11ytester-action.yml +++ b/.github/workflows/a11ytester-action.yml @@ -14,7 +14,7 @@ env: WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: - Lighthouse-CLI: + a11ytester-action-CLI: runs-on: ubuntu-latest steps: - name: Checkout @@ -24,4 +24,4 @@ jobs: - name: a11ytester uses: mikaelvesavuori/a11ytester-action@v1.0.0 with: - urls: '[$WEBSITE_TO_AUDIT]' \ No newline at end of file + urls: [${{ env.WEBSITE_TO_AUDIT }}] \ No newline at end of file diff --git a/.github/workflows/a11ywatch.yml b/.github/workflows/a11ywatch.yml index 21da9a2c7..67b3fe8a9 100644 --- a/.github/workflows/a11ywatch.yml +++ b/.github/workflows/a11ywatch.yml @@ -14,7 +14,7 @@ env: WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' jobs: - Lighthouse-CLI: + a11ywatch-CLI: runs-on: ubuntu-latest steps: - name: Checkout @@ -23,7 +23,7 @@ jobs: # @see https://github.com/marketplace/actions/web-accessibility-evaluation - uses: a11ywatch/github-action@v1.13.0 with: - WEBSITE_URL: $WEBSITE_TO_AUDIT + WEBSITE_URL: ${{ env.WEBSITE_TO_AUDIT }} SUBDOMAINS: true TLD: false SITEMAP: true From 7d2d0bd6176057fbfdbf8cf1c6e8d0c63618f554 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 16:18:39 +0100 Subject: [PATCH 13/16] Add new workflow for Lighthouse Check --- .github/workflows/lighthouse-check.yml | 31 ++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 .github/workflows/lighthouse-check.yml diff --git a/.github/workflows/lighthouse-check.yml b/.github/workflows/lighthouse-check.yml new file mode 100644 index 000000000..149525132 --- /dev/null +++ b/.github/workflows/lighthouse-check.yml @@ -0,0 +1,31 @@ +name: ♿️ A11Y CI with Lighthouse Check +on: + pull_request: + paths: + - '**/.github/workflows/lighthouse-check.yml' + - '.github/workflows/generate-site-preview.yml' + - 'src/**/*' + - 'package.json' + - 'package-lock.json' + - 'gatsby-*.js' + - '.nvmrc' + +env: + WEBSITE_TO_AUDIT: 'https://process-analytics-process-analytics-dev-site_preview-pr-${{ github.event.pull_request.number }}.surge.sh/' + +jobs: + Lighthouse-Check-CLI: + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v3 + # Using the Lighthouse Check GitHub Action + # @see https://github.com/marketplace/actions/lighthouse-check + - name: Run Lighthouse Check GitHub Action + uses: foo-software/lighthouse-check-action@master + id: lighthouse_audit + with: + urls: ${{ env.WEBSITE_TO_AUDIT }} + gitHubAccessToken: ${{ secrets.GH_RELEASE_TOKEN }} + prCommentEnabled: true + prCommentSaveOld: false \ No newline at end of file From be1505127d32535fe1ee4b4ffc06a50ae87f5551 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 16:34:16 +0100 Subject: [PATCH 14/16] Change workflow --- .github/workflows/a11ytester-action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/a11ytester-action.yml b/.github/workflows/a11ytester-action.yml index d0b586b4e..1be021b24 100644 --- a/.github/workflows/a11ytester-action.yml +++ b/.github/workflows/a11ytester-action.yml @@ -24,4 +24,4 @@ jobs: - name: a11ytester uses: mikaelvesavuori/a11ytester-action@v1.0.0 with: - urls: [${{ env.WEBSITE_TO_AUDIT }}] \ No newline at end of file + urls: ${{ env.WEBSITE_TO_AUDIT }} \ No newline at end of file From 49ed8a442ade9507eb1158af27353eac30c6295f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Thu, 9 Feb 2023 16:40:21 +0100 Subject: [PATCH 15/16] Update workflow for Lighthouse Check --- .github/workflows/lighthouse-check.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lighthouse-check.yml b/.github/workflows/lighthouse-check.yml index 149525132..3a73a9432 100644 --- a/.github/workflows/lighthouse-check.yml +++ b/.github/workflows/lighthouse-check.yml @@ -28,4 +28,5 @@ jobs: urls: ${{ env.WEBSITE_TO_AUDIT }} gitHubAccessToken: ${{ secrets.GH_RELEASE_TOKEN }} prCommentEnabled: true - prCommentSaveOld: false \ No newline at end of file + prCommentSaveOld: false + device: all \ No newline at end of file From c779d112504d4c55fba51f2cb077f5fd6d2c3f98 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Souchet=20C=C3=A9line?= Date: Fri, 22 Sep 2023 14:42:09 +0200 Subject: [PATCH 16/16] Bump the version of actions --- .github/workflows/a11ywatch.yml | 2 +- .github/workflows/axe-core.yml | 6 ++---- .github/workflows/lighthouse.yml | 4 ++-- .github/workflows/pa11y.yml | 2 +- 4 files changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/workflows/a11ywatch.yml b/.github/workflows/a11ywatch.yml index 67b3fe8a9..af610c758 100644 --- a/.github/workflows/a11ywatch.yml +++ b/.github/workflows/a11ywatch.yml @@ -21,7 +21,7 @@ jobs: uses: actions/checkout@v3 # Using the Web Accessibility Evaluation GitHub Action # @see https://github.com/marketplace/actions/web-accessibility-evaluation - - uses: a11ywatch/github-action@v1.13.0 + - uses: a11ywatch/github-action@v2.0.2 with: WEBSITE_URL: ${{ env.WEBSITE_TO_AUDIT }} SUBDOMAINS: true diff --git a/.github/workflows/axe-core.yml b/.github/workflows/axe-core.yml index a63fb1313..16113b307 100644 --- a/.github/workflows/axe-core.yml +++ b/.github/workflows/axe-core.yml @@ -20,15 +20,13 @@ jobs: - name: Checkout uses: actions/checkout@v3 - name: Use Chrome Driver - uses: nanasess/setup-chromedriver@v1 - with: - chromedriver-version: '108.0.5359.71' + uses: nanasess/setup-chromedriver@v2 - name: Install Axe CLI run: npm install -g @axe-core/cli - name: Run Axe CLI id: axe - uses: mathiasvr/command-output@v1 + uses: mathiasvr/command-output@v2.0.0 with: run: axe $WEBSITE_TO_AUDIT --chromedriver-path="/usr/local/bin/chromedriver" --exit --tags wcag2aaa diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml index 11db0bbe1..985fe988a 100644 --- a/.github/workflows/lighthouse.yml +++ b/.github/workflows/lighthouse.yml @@ -24,7 +24,7 @@ jobs: # Using the Lighthouse GitHub Action # @see https://github.com/marketplace/actions/lighthouse-ci-action - name: Run Lighthouse GitHub Action - uses: treosh/lighthouse-ci-action@v9 + uses: treosh/lighthouse-ci-action@v10 id: lighthouse_audit with: urls: $WEBSITE_TO_AUDIT @@ -34,7 +34,7 @@ jobs: - name: Format lighthouse score if: always() id: format_lighthouse_score - uses: actions/github-script@v5 + uses: actions/github-script@v6 with: script: | const lighthouseCommentMaker = require('./.github/workflows/lighthouse-comment.js'); diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml index 1918efb80..8ad6a042a 100644 --- a/.github/workflows/pa11y.yml +++ b/.github/workflows/pa11y.yml @@ -24,7 +24,7 @@ jobs: run: npm install -g pa11y-ci - name: Run Pa11y CLI id: pa11y - uses: mathiasvr/command-output@v1 + uses: mathiasvr/command-output@v2.0.0 with: run: pa11y-ci $WEBSITE_TO_AUDIT -c ./.pa11yci - name: Comment pull request