Broken GitHub links from gallery examples#2111
Merged
kandersolar merged 9 commits intoJul 1, 2024
Merged
Conversation
IoannisSifnaios
changed the title
kandersolar
reviewed
Jun 28, 2024
kandersolar
left a comment
kandersolar
left a comment
Member
There was a problem hiding this comment.
Looks like the "view on GH" links on these types of pages are still broken:
This reverts commit 3cc357d.
Member
Author
|
Thanks @kandersolar! I think it is fixed now. Is this something that needs to be added to the whatsnew file? |
kandersolar
approved these changes
Jul 1, 2024
kandersolar
left a comment
kandersolar
left a comment
Member
There was a problem hiding this comment.
LGTM. No need for a whatsnew entry IMHO. Thanks @IoannisSifnaios!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.