bpo-43269: Remove redundant extern keywords (GH-24605)

Erlend Egeberg Aasland · web-flow · commit 38b6c2acd4bb · 2021-02-21T12:07:49.000+02:00
diff --git a/Modules/_sqlite/cache.c b/Modules/_sqlite/cache.c
@@ -296,7 +296,8 @@ static PyType_Spec cache_spec = {
 };
 PyTypeObject *pysqlite_CacheType = NULL;
 
-extern int pysqlite_cache_setup_types(PyObject *mod)
+int
+pysqlite_cache_setup_types(PyObject *mod)
 {
     pysqlite_NodeType = (PyTypeObject *)PyType_FromModuleAndSpec(mod, &node_spec, NULL);
     if (pysqlite_NodeType == NULL) {
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -1927,7 +1927,8 @@ static PyType_Spec connection_spec = {
 
 PyTypeObject *pysqlite_ConnectionType = NULL;
 
-extern int pysqlite_connection_setup_types(PyObject *module)
+int
+pysqlite_connection_setup_types(PyObject *module)
 {
     pysqlite_ConnectionType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &connection_spec, NULL);
     if (pysqlite_ConnectionType == NULL) {
diff --git a/Modules/_sqlite/cursor.c b/Modules/_sqlite/cursor.c
@@ -1017,7 +1017,8 @@ static PyType_Spec cursor_spec = {
 
 PyTypeObject *pysqlite_CursorType = NULL;
 
-extern int pysqlite_cursor_setup_types(PyObject *module)
+int
+pysqlite_cursor_setup_types(PyObject *module)
 {
     pysqlite_CursorType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &cursor_spec, NULL);
     if (pysqlite_CursorType == NULL) {
diff --git a/Modules/_sqlite/prepare_protocol.c b/Modules/_sqlite/prepare_protocol.c
@@ -55,7 +55,8 @@ static PyType_Spec type_spec = {
 
 PyTypeObject *pysqlite_PrepareProtocolType = NULL;
 
-extern int pysqlite_prepare_protocol_setup_types(PyObject *module)
+int
+pysqlite_prepare_protocol_setup_types(PyObject *module)
 {
     pysqlite_PrepareProtocolType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &type_spec, NULL);
     if (pysqlite_PrepareProtocolType == NULL) {
diff --git a/Modules/_sqlite/row.c b/Modules/_sqlite/row.c
@@ -243,7 +243,8 @@ static PyType_Spec row_spec = {
 
 PyTypeObject *pysqlite_RowType = NULL;
 
-extern int pysqlite_row_setup_types(PyObject *module)
+int
+pysqlite_row_setup_types(PyObject *module)
 {
     pysqlite_RowType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &row_spec, NULL);
     if (pysqlite_RowType == NULL) {
diff --git a/Modules/_sqlite/statement.c b/Modules/_sqlite/statement.c
@@ -480,7 +480,8 @@ static PyType_Spec stmt_spec = {
 };
 PyTypeObject *pysqlite_StatementType = NULL;
 
-extern int pysqlite_statement_setup_types(PyObject *module)
+int
+pysqlite_statement_setup_types(PyObject *module)
 {
     pysqlite_StatementType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &stmt_spec, NULL);
     if (pysqlite_StatementType == NULL) {

Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,8 @@ static PyType_Spec cache_spec = {`
`296`	`296`	`};`
`297`	`297`	`PyTypeObject *pysqlite_CacheType = NULL;`
`298`	`298`
`299`		`-extern int pysqlite_cache_setup_types(PyObject *mod)`
	`299`	`+int`
	`300`	`+pysqlite_cache_setup_types(PyObject *mod)`
`300`	`301`	`{`
`301`	`302`	`pysqlite_NodeType = (PyTypeObject *)PyType_FromModuleAndSpec(mod, &node_spec, NULL);`
`302`	`303`	`if (pysqlite_NodeType == NULL) {`
Original file line number	Diff line number	Diff line change
`@@ -1927,7 +1927,8 @@ static PyType_Spec connection_spec = {`
`1927`	`1927`
`1928`	`1928`	`PyTypeObject *pysqlite_ConnectionType = NULL;`
`1929`	`1929`
`1930`		`-extern int pysqlite_connection_setup_types(PyObject *module)`
	`1930`	`+int`
	`1931`	`+pysqlite_connection_setup_types(PyObject *module)`
`1931`	`1932`	`{`
`1932`	`1933`	`pysqlite_ConnectionType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &connection_spec, NULL);`
`1933`	`1934`	`if (pysqlite_ConnectionType == NULL) {`
Original file line number	Diff line number	Diff line change
`@@ -1017,7 +1017,8 @@ static PyType_Spec cursor_spec = {`
`1017`	`1017`
`1018`	`1018`	`PyTypeObject *pysqlite_CursorType = NULL;`
`1019`	`1019`
`1020`		`-extern int pysqlite_cursor_setup_types(PyObject *module)`
	`1020`	`+int`
	`1021`	`+pysqlite_cursor_setup_types(PyObject *module)`
`1021`	`1022`	`{`
`1022`	`1023`	`pysqlite_CursorType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &cursor_spec, NULL);`
`1023`	`1024`	`if (pysqlite_CursorType == NULL) {`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ static PyType_Spec type_spec = {`
`55`	`55`
`56`	`56`	`PyTypeObject *pysqlite_PrepareProtocolType = NULL;`
`57`	`57`
`58`		`-extern int pysqlite_prepare_protocol_setup_types(PyObject *module)`
	`58`	`+int`
	`59`	`+pysqlite_prepare_protocol_setup_types(PyObject *module)`
`59`	`60`	`{`
`60`	`61`	`pysqlite_PrepareProtocolType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &type_spec, NULL);`
`61`	`62`	`if (pysqlite_PrepareProtocolType == NULL) {`
Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,8 @@ static PyType_Spec row_spec = {`
`243`	`243`
`244`	`244`	`PyTypeObject *pysqlite_RowType = NULL;`
`245`	`245`
`246`		`-extern int pysqlite_row_setup_types(PyObject *module)`
	`246`	`+int`
	`247`	`+pysqlite_row_setup_types(PyObject *module)`
`247`	`248`	`{`
`248`	`249`	`pysqlite_RowType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &row_spec, NULL);`
`249`	`250`	`if (pysqlite_RowType == NULL) {`
Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,8 @@ static PyType_Spec stmt_spec = {`
`480`	`480`	`};`
`481`	`481`	`PyTypeObject *pysqlite_StatementType = NULL;`
`482`	`482`
`483`		`-extern int pysqlite_statement_setup_types(PyObject *module)`
	`483`	`+int`
	`484`	`+pysqlite_statement_setup_types(PyObject *module)`
`484`	`485`	`{`
`485`	`486`	`pysqlite_StatementType = (PyTypeObject *)PyType_FromModuleAndSpec(module, &stmt_spec, NULL);`
`486`	`487`	`if (pysqlite_StatementType == NULL) {`