Improve the assertion.

gpshead · serhiy-storchaka · web-flow · commit 52a475c4ec77 · 2023-12-04T12:36:43.000-08:00
Co-authored-by: Serhiy Storchaka &lt;storchaka@gmail.com&gt;
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
@@ -768,7 +768,7 @@ child_exec(char *const exec_array[],
 
 #ifdef HAVE_SETGROUPS
     if (extra_group_size >= 0) {
-        assert((extra_group_size == 0 && extra_groups == NULL) || extra_group_size);
+        assert((extra_group_size == 0) == (extra_groups == NULL));
         POSIX_CALL(setgroups(extra_group_size, extra_groups));
     }
 #endif /* HAVE_SETGROUPS */

Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,7 @@ child_exec(char *const exec_array[],`
`768`	`768`
`769`	`769`	`#ifdef HAVE_SETGROUPS`
`770`	`770`	`if (extra_group_size >= 0) {`
`771`		`- assert((extra_group_size == 0 && extra_groups == NULL) \|\| extra_group_size);`
	`771`	`+ assert((extra_group_size == 0) == (extra_groups == NULL));`
`772`	`772`	`POSIX_CALL(setgroups(extra_group_size, extra_groups));`
`773`	`773`	`}`
`774`	`774`	`#endif /* HAVE_SETGROUPS */`