Add tests

Author: vstinner

Lib/test/test_threading.py

@@ -2103,6 +2103,26 @@ def test__all__(self):
         support.check__all__(self, threading, ('threading', '_thread'),
                              extra=extra, not_exported=not_exported)
 
+    def test_set_name(self):
+        try:
+            get_name = _thread._get_name
+            set_name = _thread.set_name
+        except AttributeError:
+            self.skipTest("need thread._get_name() and thread.set_name()")
+
+        work_name = None
+        def work():
+            nonlocal work_name
+            work_name = get_name()
+
+        # name not too long to fit into Linux 15 bytes limit
+        name = "CustomName"
+
+        thread = threading.Thread(target=work, name=name)
+        thread.start()
+        thread.join()
+        self.assertEqual(work_name, name)
+
 
 class InterruptMainTests(unittest.TestCase):
     def check_interrupt_main_with_signal_handler(self, signum):

Modules/_threadmodule.c

@@ -2364,19 +2364,45 @@ Internal only. Return a non-zero integer that uniquely identifies the main threa
 of the main interpreter.");
 
 
+#ifdef HAVE_PTHREAD_SETNAME_NP
+/*[clinic input]
+_thread._get_name
+
+Get the name of the current thread.
+[clinic start generated code]*/
+
+static PyObject *
+_thread__get_name_impl(PyObject *module)
+/*[clinic end generated code: output=20026e7ee3da3dd7 input=35cec676833d04c8]*/
+{
+    char name[17];
+    size_t size = Py_ARRAY_LENGTH(name) - 1;
+#ifdef __APPLE__
+    pthread_getname_np(name, size);
+#else
+    pthread_t thread = pthread_self();
+    pthread_getname_np(thread, name, size);
+#endif
+    name[size] = 0;
+    return PyUnicode_DecodeFSDefault(name);
+}
+#endif  // HAVE_PTHREAD_SETNAME_NP
+
+
 #ifdef HAVE_PTHREAD_SETNAME_NP
 /*[clinic input]
 _thread.set_name
 
-    name: str
+    name as name_obj: object(converter="PyUnicode_FSConverter")
 
 Set the name of the current thread.
 [clinic start generated code]*/
 
 static PyObject *
-_thread_set_name_impl(PyObject *module, const char *name)
-/*[clinic end generated code: output=f051ce549bcd6b8e input=7e29bbdbfb046a04]*/
+_thread_set_name_impl(PyObject *module, PyObject *name_obj)
+/*[clinic end generated code: output=402b0c68e0c0daed input=a0459bd64f771808]*/
 {
+    const char *name = PyBytes_AS_STRING(name_obj);
 #ifdef __APPLE__
     pthread_setname_np(name);
 #else
@@ -2428,6 +2454,7 @@ static PyMethodDef thread_methods[] = {
     {"_get_main_thread_ident", thread__get_main_thread_ident,
      METH_NOARGS, thread__get_main_thread_ident_doc},
     _THREAD_SET_NAME_METHODDEF
+    _THREAD__GET_NAME_METHODDEF
     {NULL,                      NULL}           /* sentinel */
 };
 

Modules/clinic/_threadmodule.c.h

@@ -5107,7 +5107,7 @@ AC_CHECK_FUNCS([ \
   posix_spawn_file_actions_addclosefrom_np \
   pread preadv preadv2 process_vm_readv \
   pthread_cond_timedwait_relative_np pthread_condattr_setclock pthread_init \
-  pthread_kill pthread_setname_np \
+  pthread_kill pthread_getname_np pthread_setname_np \
   ptsname ptsname_r pwrite pwritev pwritev2 readlink readlinkat readv realpath renameat \
   rtpSpawn sched_get_priority_max sched_rr_get_interval sched_setaffinity \
   sched_setparam sched_setscheduler sem_clockwait sem_getvalue sem_open \

configure

@@ -981,6 +981,9 @@
 /* Define to 1 if you have the `pthread_getcpuclockid' function. */
 #undef HAVE_PTHREAD_GETCPUCLOCKID
 
+/* Define to 1 if you have the `pthread_getname_np' function. */
+#undef HAVE_PTHREAD_GETNAME_NP
+
 /* Define to 1 if you have the <pthread.h> header file. */
 #undef HAVE_PTHREAD_H