Skip to content

Commit f6df3f5

Browse files
committed
Remove unnecessary, too implementation dependent test.
1 parent 44d3d9e commit f6df3f5

1 file changed

Lines changed: 0 additions & 26 deletions

File tree

Lib/test/test_asyncio/test_subprocess.py

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -140,32 +140,6 @@ def test_proc_exited_no_invalid_state_error_on_exit_waiters(self):
140140

141141
transport.close()
142142

143-
def test_wait_returns_on_exit_with_open_pipe(self):
144-
# gh-119710: wait() must resolve when the process exits even if a
145-
# pipe is still open and never reaches EOF (e.g. inherited by a
146-
# grandchild). Otherwise _call_connection_lost() never runs and
147-
# _wait() would hang forever despite the returncode being known.
148-
transport, protocol = self.create_transport()
149-
150-
# Pipes are fully connected, but fd 1 stays open (never disconnects).
151-
pipe = mock.Mock()
152-
pipe.disconnected = False
153-
transport._pipes[1] = pipe
154-
155-
# A waiter registered via _wait() before the process exits.
156-
exit_waiter = self.loop.create_future()
157-
transport._exit_waiters.append(exit_waiter)
158-
159-
# _process_exited() must resolve exit_waiter even though the pipe
160-
# never disconnects (so _call_connection_lost() never runs). Without
161-
# the fix, exit_waiter stays pending forever and this hangs.
162-
transport._process_exited(7)
163-
self.loop.run_until_complete(exit_waiter)
164-
165-
self.assertEqual(exit_waiter.result(), 7)
166-
167-
transport.close()
168-
169143

170144
class SubprocessMixin:
171145

0 commit comments

Comments
 (0)