Skip to content

bpo-38588: Optimize list comparison.#17766

Merged
methane merged 1 commit into
python:masterfrom
methane:list-cmp-opt
Dec 31, 2019
Merged

bpo-38588: Optimize list comparison.#17766
methane merged 1 commit into
python:masterfrom
methane:list-cmp-opt

Conversation

@methane

@methane methane commented Dec 31, 2019

Copy link
Copy Markdown
Member

Mitigate performance regression of the list comparison caused by
2d5bf56.

https://bugs.python.org/issue38588

Mitigate performance regression of the list comparison caused by
2d5bf56.
@pablogsal

pablogsal commented Dec 31, 2019

Copy link
Copy Markdown
Member

Wouldn't this affect this case? [float("nan")] == [float("nan")]

Edit: Sorry, I checked and it should not affect it.

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the analysis and the quick fix Inada-san.

And apologies for missing the comment in bpo.

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the analysis @methane

@methane methane merged commit dfef986 into python:master Dec 31, 2019
@methane methane deleted the list-cmp-opt branch December 31, 2019 01:58
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Mitigate performance regression of the list comparison caused by 2d5bf56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants