From fd25e6cbc0f39f99e853d3cd5dfdc4baac7509b4 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Fri, 8 Jan 2021 15:01:38 +0100 Subject: [PATCH] bpo-42866: Fix refleak in CJK getcodec() (GH-24165) Fix a reference leak in the getcodec() function of CJK codecs. (cherry picked from commit e542d417b96077d04aec089505eacb990c9799ae) Co-authored-by: Victor Stinner --- .../next/Library/2021-01-08-10-57-21.bpo-42866.Y1DnrO.rst | 2 ++ Modules/cjkcodecs/cjkcodecs.h | 1 + 2 files changed, 3 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2021-01-08-10-57-21.bpo-42866.Y1DnrO.rst diff --git a/Misc/NEWS.d/next/Library/2021-01-08-10-57-21.bpo-42866.Y1DnrO.rst b/Misc/NEWS.d/next/Library/2021-01-08-10-57-21.bpo-42866.Y1DnrO.rst new file mode 100644 index 000000000000000..3ea6cc239aa6946 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2021-01-08-10-57-21.bpo-42866.Y1DnrO.rst @@ -0,0 +1,2 @@ +Fix a reference leak in the ``getcodec()`` function of CJK codecs. Patch by +Victor Stinner. diff --git a/Modules/cjkcodecs/cjkcodecs.h b/Modules/cjkcodecs/cjkcodecs.h index e41755b197ffcab..19e16aaaf21f653 100644 --- a/Modules/cjkcodecs/cjkcodecs.h +++ b/Modules/cjkcodecs/cjkcodecs.h @@ -293,6 +293,7 @@ getcodec(PyObject *self, PyObject *encoding) r = PyObject_CallOneArg(cofunc, codecobj); Py_DECREF(codecobj); + Py_DECREF(cofunc); return r; }