bpo-44114: Fix dictkeys_reversed and dictvalues_reversed function signatures#26062
Conversation
These are passed and called as PyCFunction, which looks like:
```
PyObject *PyCFunction(PyObject *self,
PyObject *args);
```
however they are defined here without the (ignored) args parameter.
This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
You should put "bpo-44114: " in your PR title. Also, you should add a news entry using blurb (item 8 in https://devguide.python.org/#quick-reference). The code itself looks good to me (though I'm no expert on the C code). I'm going to attach labels to request backports to 3.10 and 3.9. |
JelleZijlstra
added
needs backport to 3.9
needs backport to 3.10
joemarshall
changed the title
|
I think I've done the right blurb things, and renamed things right now. |
|
LGTM, but the CLA needs signing |
Can we remove this |
|
Thanks @joemarshall for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
…natures (pythonGH-26062) These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter. This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking. (cherry picked from commit ab383eb) Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk>
|
GH-26092 is a backport of this pull request to the 3.10 branch. |
|
GH-26093 is a backport of this pull request to the 3.9 branch. |
…natures (pythonGH-26062) These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter. This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking. (cherry picked from commit ab383eb) Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk>
serhiy-storchaka
added
needs backport to 3.9
needs backport to 3.10
|
Thanks @joemarshall for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @joemarshall for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Thanks @joemarshall for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-26094 is a backport of this pull request to the 3.8 branch. |
serhiy-storchaka
removed
needs backport to 3.10
…natures (GH-26062) These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter. This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking. (cherry picked from commit ab383eb) Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk>
…natures (GH-26062) (GH-26093) These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter. This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking. (cherry picked from commit ab383eb) Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk> Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk>
8 participants
Fix for bug number 44114
These are passed and called as PyCFunction, which looks like:
however they are defined here without the (ignored) args parameter.
This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking.
https://bugs.python.org/issue44114