bpo-45831: _Py_DumpASCII() uses a single write() call if possible#29596
Merged
Conversation
ambv
changed the title
If the string is ASCII only and doesn't need to escape characters, write the whole string with a single write() syscall.
erlend-aasland
approved these changes
Nov 17, 2021
Contributor
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2021
…thonGH-29596) If the string is ASCII only and doesn't need to escape characters, write the whole string with a single write() syscall. (cherry picked from commit b919d81) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-29597 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 17, 2021
…thonGH-29596) If the string is ASCII only and doesn't need to escape characters, write the whole string with a single write() syscall. (cherry picked from commit b919d81) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-29598 is a backport of this pull request to the 3.10 branch. |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…thonGH-29596) If the string is ASCII only and doesn't need to escape characters, write the whole string with a single write() syscall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the string is ASCII only and doesn't need to escape characters,
write the whole string with a single write() syscall.
https://bugs.python.org/issue45831