From 298ea38f08785b488367f2ab5e86520ab03f9963 Mon Sep 17 00:00:00 2001 From: Yury Selivanov Date: Tue, 11 Jan 2022 13:15:38 -0800 Subject: [PATCH] bpo-46347: Fix memory leak in PyEval_EvalCodeEx. First introduced in 0332e569c12d3dc97171546c6dc10e42c27de34b --- .../2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst | 1 + Python/ceval.c | 7 ------- 2 files changed, 1 insertion(+), 7 deletions(-) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst new file mode 100644 index 00000000000000..fc12d6ba146caa --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2022-01-11-13-57-00.bpo-46347.Gd8M-S.rst @@ -0,0 +1 @@ +Fix memory leak in PyEval_EvalCodeEx. diff --git a/Python/ceval.c b/Python/ceval.c index be26ffd822c136..85b4400de32f49 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -6128,16 +6128,9 @@ PyEval_EvalCodeEx(PyObject *_co, PyObject *globals, PyObject *locals, } allargs = newargs; } - PyObject **kwargs = PyMem_Malloc(sizeof(PyObject *)*kwcount); - if (kwargs == NULL) { - res = NULL; - Py_DECREF(kwnames); - goto fail; - } for (int i = 0; i < kwcount; i++) { Py_INCREF(kws[2*i]); PyTuple_SET_ITEM(kwnames, i, kws[2*i]); - kwargs[i] = kws[2*i+1]; } PyFrameConstructor constr = { .fc_globals = globals,