Skip to content

bpo-46445: cover multiple inheritance of TypedDict in test_typing#30719

Merged
gvanrossum merged 3 commits into
python:mainfrom
sobolevn:issue-46445
Jan 21, 2022
Merged

bpo-46445: cover multiple inheritance of TypedDict in test_typing#30719
gvanrossum merged 3 commits into
python:mainfrom
sobolevn:issue-46445

Conversation

@sobolevn

@sobolevn sobolevn commented Jan 20, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 20, 2022
sobolevn
sobolevn commented Jan 20, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py
from typing import is_typeddict
from typing import no_type_check, no_type_check_decorator
from typing import Type
from typing import NewType

@sobolevn sobolevn Jan 20, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related, but it was unused and I felt like there's no need to create a separate PR for this. If required, I can revert this change.

@sobolevn sobolevn closed this Jan 20, 2022
@sobolevn sobolevn reopened this Jan 20, 2022
JelleZijlstra
JelleZijlstra requested changes Jan 21, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py
@gvanrossum

gvanrossum commented Jan 21, 2022

Copy link
Copy Markdown
Member

Should I merge or wait?

@JelleZijlstra

JelleZijlstra commented Jan 21, 2022

Copy link
Copy Markdown
Member

I think it's ready to merge.

@gvanrossum gvanrossum merged commit 65b88d5 into python:main Jan 21, 2022
@miss-islington

miss-islington commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 21, 2022
@sobolevn @miss-islington
bpo-46445: Cover multiple inheritance of TypedDict in test_typing (…
44ecd0d 
…pythonGH-30719)

(cherry picked from commit 65b88d5)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington

miss-islington commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 65b88d5e01c845c0cfa3ff61bc8b2faec8f67a57 3.9

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 21, 2022
@bedevere-bot

bedevere-bot commented Jan 21, 2022

Copy link
Copy Markdown

GH-30770 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this pull request Jan 21, 2022
@miss-islington @sobolevn
bpo-46445: Cover multiple inheritance of TypedDict in test_typing (…
46e6aad 
…GH-30719)

(cherry picked from commit 65b88d5)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@gvanrossum gvanrossum

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn @gvanrossum @JelleZijlstra @miss-islington @bedevere-bot @the-knights-who-say-ni @ZeroIntensity