Skip to content

bpo-31812: Add documentation translations to What's New in Python 3.7.#4064

Merged
vstinner merged 1 commit into
python:masterfrom
JulienPalard:issue31812
Oct 24, 2017
Merged

bpo-31812: Add documentation translations to What's New in Python 3.7.#4064
vstinner merged 1 commit into
python:masterfrom
JulienPalard:issue31812

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Oct 20, 2017

Copy link
Copy Markdown
Member

Comment thread Doc/whatsnew/3.7.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add labels to link. Like French documentation <...>_ (French GitHub project <...>_).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention was to show the URLS, not only to give links. The URLs themseve are an information in this context, from my point of view. But the documentation link may be a more important information than the github URL, and having a square of four URLs may be huge, why not:

- Japanese: https://docs.python.org/ja/ (`repository <...>`_)
- French: https://docs.python.org/fr/ (`repository <...>`_)

Comment thread Doc/whatsnew/3.7.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace "a PEP" with :pep:545 to get a link.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right. fixed, and had to reword for consistency.

Comment thread Doc/whatsnew/3.7.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you add this link?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted every titles about PEPs had a link so I just added a link too.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Just reformat to separate the two links of a language.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my comment was for the http links below.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JulienPalard JulienPalard force-pushed the issue31812 branch 2 times, most recently from 708dd8a to 718b058 Compare October 20, 2017 21:05

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread Doc/whatsnew/3.7.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps change this:

describes the process to translate Python documentations, and two translation has been added:

to:

describes the process to translate Python documentation, and two translations have been added:

Summary:

  • s/documentations/documentation/
  • s/translation/translations/
  • s/has/have/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vstinner

Copy link
Copy Markdown
Member

Thanks @JulienPalard for the PR and @dianaclarke for the review!

@JulienPalard JulienPalard deleted the issue31812 branch June 16, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants