bpo-32413: Add documentation that at the module level, locals(), globals() are the same dictionary#5004
Merged
Conversation
Contributor
Author
|
back port needed for 2.7, 3.4, 3.5, 3.6, 3.7 |
Contributor
Author
|
@rhettinger Could you please take a look? |
Contributor
Author
|
@merwok Could you please review? |
Contributor
Author
|
@methane Could you please review? |
Contributor
Author
|
@terryjreedy Could you please take a look? |
Carreau
approved these changes
Jun 24, 2018
Member
|
Once CI clears this will get merged. Thanks everyone! @srinivasreddy in the future, please refrain @ mentioning so many people to try and get a review. The appropriate way to request a review is to email python-dev if no one has reviewed your PR in a month. |
brettcannon
approved these changes
Apr 2, 2019
Contributor
|
Thanks @srinivasreddy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-12664 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2019
…als() are the same dictionary (pythonGH-5004) https://bugs.python.org/issue32413 (cherry picked from commit 1c5fa5a) Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2019
…als() are the same dictionary (GH-5004) https://bugs.python.org/issue32413 (cherry picked from commit 1c5fa5a) Co-authored-by: Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి) <thatiparthysreenivas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32413