Skip to content

bpo-33711: Fix license generation error in msi.py#7241

Merged
zware merged 2 commits into
python:2.7from
native-api:msi_license_error
Jun 24, 2018
Merged

bpo-33711: Fix license generation error in msi.py#7241
zware merged 2 commits into
python:2.7from
native-api:msi_license_error

Conversation

@native-api

@native-api native-api commented May 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor 
c:\Users\Sasha\Documents\cpython\Tools\msi>python msi.py
Traceback (most recent call last):
  File "msi.py", line 1372, in <module>
    add_files(db)
  File "msi.py", line 956, in add_files
    generate_license()
  File "msi.py", line 928, in generate_license
    raise ValueError, "Could not find "+srcdir+"/externals/"+pat
ValueError: Could not find c:\Users\Sasha\Documents\cpython/externals/db-*

The dir in externals is actually called bsddb-<version>.
Bug caused by 986b7ff .
Doesn't affect 3.x 'cuz the bsddb module has been dropped.

https://bugs.python.org/issue33711

@native-api native-api changed the title Fix license generation error in msi.py bpo-33711: Fix license generation error in msi.py May 31, 2018
@akruis

akruis commented Jun 24, 2018

Copy link
Copy Markdown

Had the same problem. The patch works for me.

@zware zware merged commit b18f098 into python:2.7 Jun 24, 2018
@native-api native-api deleted the msi_license_error branch June 25, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@native-api @akruis @zware @the-knights-who-say-ni @bedevere-bot