Skip to content

Fix GCC warning in Python/hamt.c#7618

Merged
methane merged 1 commit into
python:masterfrom
ZackerySpytz:gcc_warning_hamt
Jul 6, 2018
Merged

Fix GCC warning in Python/hamt.c#7618
methane merged 1 commit into
python:masterfrom
ZackerySpytz:gcc_warning_hamt

Conversation

@ZackerySpytz

Copy link
Copy Markdown
Contributor

This warning is present in the Travis builds for master and 3.7.

Python/hamt.c: In function ‘_PyHamt_Without’:
Python/hamt.c:2371:76: warning: ‘new_root’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Py_DECREF(new_root);
^
Python/hamt.c: In function ‘hamt_py_delete’:
Python/hamt.c:2371:76: warning: ‘new_root’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Python/hamt.c:2351:17: note: ‘new_root’ was declared here
PyHamtNode *new_root;

@ZackerySpytz ZackerySpytz requested a review from 1st1 as a code owner June 11, 2018 06:03
@zhangyangyu zhangyangyu changed the title [Skip Issue] Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Jun 27, 2018
@methane methane changed the title Fix GCC warning (-Wmaybe-uninitialized) in Python/hamt.c Fix GCC warning in Python/hamt.c Jul 6, 2018
@methane methane merged commit d8c3e82 into python:master Jul 6, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-8135 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2018
(cherry picked from commit d8c3e82)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jul 6, 2018
(cherry picked from commit d8c3e82)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@ZackerySpytz ZackerySpytz deleted the gcc_warning_hamt branch July 12, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants