Commit 3bfa605
Allow triagers to close PRs if the PR is of very low quality (#828)
As discussed on the CPython core-dev discord channel, there are several issues of the current policy that states that triagers should never close PRS:
- Github's setup allows members of the triage team to close PRs, regardless of the policy stated in the devguide.
- This policy isn't consistently followed by all members of the triage team. Some triagers occasionally close PRs (I have closed one or two myself in situations where it seemed abundantly clear that there was no prospect of the PR being merged).
- This policy isn't really enforced in any way if triagers do close PRs. This lack of enforcement seems to be an implicit endorsement of the idea that it is okay for triagers to close PRs in some circumstances.
- It feels silly to have to bother a core dev with a request for a PR to be closed if it's self-evident that it should be closed (e.g. if the PR makes changes to a deprecated module, makes solely cosmetic changes to a module, or simply has a 0% chance of ever being merged)
- Changing this policy will help towards the goal of reducing the CPython PR backlog
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>1 parent 0764536 commit 3bfa605
1 file changed
Lines changed: 19 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
39 | | - | |
40 | | - | |
| 38 | + | |
| 39 | + | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
44 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
45 | 59 | | |
46 | 60 | | |
47 | 61 | | |
48 | | - | |
| 62 | + | |
49 | 63 | | |
50 | 64 | | |
51 | 65 | | |
| |||
0 commit comments